Repository navigation
fix: explain unavailable cost in offload ls - #12
Merged
Merged
Conversation
promptui.Prompt shares its cursor with readline's listener goroutine, which fails go test -race. Read the secret with readline directly and keep masked echo; the test assertions are unchanged. Refs #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
改动
CI 修复(单独一个 commit)
TestTerminalSettingsSecretIsMasked 在 go test -race 下失败(promptui Cursor/ScreenBuf 竞争,基线 ff0a109 已有)。Secret 改为直接使用 readline 实现掩码回显,并避免在 Enter 之后写屏。测试断言未改动,未关闭 race 检查。
测试
假设