Skip to content

Exclude the tools directory from the wheel - #1005

Merged
puddly merged 1 commit into
zigpy:devfrom
thomas-roos:exclude-tools-package
Nov 7, 2026
Merged

puddly merged 1 commit into
zigpy:devfrom
thomas-roos:exclude-tools-package

Conversation

@thomas-roos

@thomas-roos thomas-roos commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

The automatic package discovery picks up the development scripts in
tools/ as a top-level "tools" package, so the wheel installs
site-packages/tools/. zigpy ships its own tools/ the same way, and the
two packages then overwrite each other's files. System package managers
refuse to install both because of the file conflict.

Found while packaging zigpy and zha for Home Assistant 2026.11 in meta-homeassistant (Yocto), where both packages install site-packages/tools/: meta-homeassistant/meta-homeassistant#207

The same change for zigpy: zigpy/zigpy#1954

🤖 Generated with Claude Code

https://claude.ai/code/session_01FimvFQ6GCZWLoFogVCUeAK

The automatic package discovery picks up the development scripts in
tools/ as a top-level "tools" package, so the wheel installs
site-packages/tools/. zigpy ships its own tools/ the same way, and the
two packages then overwrite each other's files. System package managers
refuse to install both because of the file conflict.

Signed-off-by: Thomas Roos <thomas@roosesweb.de>
@puddly
puddly enabled auto-merge (squash) November 7, 2026 17:17
@puddly
puddly merged commit 2da1a5b into zigpy:dev Nov 7, 2026
8 checks passed
@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (cf3129e) to head (8f8a66c).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1005   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          61       61           
  Lines       10870    10870           
=======================================
  Hits        10597    10597           
  Misses        273      273           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants