Repository navigation
Remove unused TypeVars and ParamSpecs - #1014
Open
zigpy-review-bot wants to merge 1 commit into
Open
zigpy-review-bot wants to merge 1 commit into
zigpy-review-bot wants to merge 1 commit into
Conversation
Drop the orphaned _Ts TypeVarTuple in zha.async_, _R in zha.application.gateway and _T/_R/_P in zha.application.helpers, plus their now-unused imports.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1014 +/- ##
==========================================
- Coverage 97.48% 97.48% -0.01%
==========================================
Files 61 61
Lines 10870 10865 -5
==========================================
- Hits 10597 10592 -5
Misses 273 273 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
puddly
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes leftover type variables that are defined but never used, as reported in #999.
Changes
zha/async_.py: remove the unused_Ts = TypeVarTuple("_Ts")and its import.zha/application/gateway.py: remove the unused_RTypeVar and theTypeVarimport.zha/application/helpers.py: remove the unused_T,_Rand_Pand theParamSpec/TypeVarimports.No behaviour change. The remaining type variables in the package are all referenced (checked per name with grep).
Testing
zha/are clean.tests/test_gateway.py,tests/test_async_.pyandtests/test_application_helpers.py: 114 passed.Fixes #999