Repository navigation
Restore children with rx_on_when_idle=0 - #17
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the change restoring sleepy-device behavior for restored children.
No open issues 🎉
What changed in this PR
Fixes #15 by restoring children with rx_on_when_idle=0, so sleepy end devices can continue receiving commands after migration or restart.
Changes:
- Defaults restored children to sleepy-device behavior when backups lack capability information.
- Adds a regression assertion for the restored
rx_on_when_idlevalue.
| File | Description |
|---|---|
zigpy_ziggurat/zigbee/application.py |
Sets rx_on_when_idle to 0 when restoring children. |
tests/test_application.py |
Verifies restored children have rx_on_when_idle=0. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 1213 1213
=========================================
Hits 1213 1213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.
This is a simple typo but it does expose a gap in the API: there (rarely) can be children with
rx_on_when_idle=Trueand these would be incorrectly restored. We should expand the wire API to allow both fields to be set.