Skip to content

enhance: update milvus-common for native async file reads - #1899

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
chasingegg:codex/milvus-common-156ad89
Oct 19, 2026
Merged

sre-ci-robot merged 1 commit into
zilliztech:mainfrom
chasingegg:codex/milvus-common-156ad89

Conversation

@chasingegg

@chasingegg chasingegg commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Upgrade milvus-common to 1.0.0-156ad89@milvus/dev#9e7341fe3656f999afb8fe46e828d578, which includes native LocalInputStream::ReadAtAsync support from zilliztech/milvus-common#139. File-based consumers can use the asynchronous interface through the existing milvus::LocalFileManager without a custom wrapper.

The dependency recipe is published by milvus-io/conanfiles#200. This PR only updates the dependency reference.

Related: zilliztech/cardinal#981
Issue: #1897

Validation:

  • Conan installation and the Knowhere + Cardinal ASAN build passed, with compile pruning enabled and current index version 11 to match Cardinal integration CI.
  • All 46 related DiskANN, nullable (excluding matrix), and minhash cases / 744,424 assertions passed in one process (391 seconds, exit code 0). ASAN_OPTIONS=detect_leaks=1:halt_on_error=1; no ASAN or LeakSanitizer reports. The validation ran outside the filesystem sandbox so LeakSanitizer could inspect threads.
  • Pre-commit and git diff --check passed. The final diff contains only the dependency reference.
  • Cardinal 98f150f7 with the same dependency: all 337 Release cases passed, including native local-file synchronous/async loading coverage.

Fresh PR CI is in progress.

Signed-off-by: chasingegg <chao.gao@zilliz.com>

@foxspy foxspy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added the ci-passed label Oct 19, 2026
@sre-ci-robot
sre-ci-robot merged commit 729e372 into zilliztech:main Oct 19, 2026
13 checks passed
@chasingegg
chasingegg deleted the codex/milvus-common-156ad89 branch October 19, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants