Repository navigation
enhance: update milvus-common for native async file reads - #1899
Merged
sre-ci-robot merged 1 commit intoOct 19, 2026
Merged
Conversation
Signed-off-by: chasingegg <chao.gao@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chasingegg, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade milvus-common to
1.0.0-156ad89@milvus/dev#9e7341fe3656f999afb8fe46e828d578, which includes nativeLocalInputStream::ReadAtAsyncsupport from zilliztech/milvus-common#139. File-based consumers can use the asynchronous interface through the existingmilvus::LocalFileManagerwithout a custom wrapper.The dependency recipe is published by milvus-io/conanfiles#200. This PR only updates the dependency reference.
Related: zilliztech/cardinal#981
Issue: #1897
Validation:
ASAN_OPTIONS=detect_leaks=1:halt_on_error=1; no ASAN or LeakSanitizer reports. The validation ran outside the filesystem sandbox so LeakSanitizer could inspect threads.git diff --checkpassed. The final diff contains only the dependency reference.98f150f7with the same dependency: all 337 Release cases passed, including native local-file synchronous/async loading coverage.Fresh PR CI is in progress.