Repository navigation
chore: Fix high-level symlink extraction logic, disable some tests in miri, and fix some typos - #1035
Conversation
There was a problem hiding this comment.
The code changes look correct. The not(miri) attributes are appropriately added to tests that perform actual filesystem symlink operations, which miri cannot support. The typo fixes in comments are also appropriate.
However, the PR title "test: Fix: disable some symlink extraction tests in miri" does not conform to Conventional Commits format, which requires a single type prefix. It should be either "test: disable some symlink extraction tests in miri" or "fix: disable some symlink extraction tests in miri" (not both "test: Fix:").
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
… and ExtractNoRestrictions needs cfg-guard
|
@Its-Just-Nans Could you please help fix this failing test? |
|
@Pr0methean any reason for
|
They create a temp dir, which miri's isolation does not allow; the endianness job runs the tests under miri since zip-rs#1035, which marked its own file-system tests the same way.
Uh oh!
There was an error while loading. Please reload this page.