Skip to content

chore: Fix high-level symlink extraction logic, disable some tests in miri, and fix some typos - #1035

Merged
Pr0methean merged 29 commits into
masterfrom
fix-nomiri
Oct 7, 2026
Merged

Pr0methean merged 29 commits into
masterfrom
fix-nomiri

Conversation

@Pr0methean

@Pr0methean Pr0methean commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look correct. The not(miri) attributes are appropriately added to tests that perform actual filesystem symlink operations, which miri cannot support. The typo fixes in comments are also appropriate.

However, the PR title "test: Fix: disable some symlink extraction tests in miri" does not conform to Conventional Commits format, which requires a single type prefix. It should be either "test: disable some symlink extraction tests in miri" or "fix: disable some symlink extraction tests in miri" (not both "test: Fix:").


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@Pr0methean Pr0methean changed the title test: Fix: disable some symlink extraction tests in miri test: Fix: disable some symlink extraction tests in miri, and fix some typos Oct 6, 2026
@Pr0methean Pr0methean changed the title test: Fix: disable some symlink extraction tests in miri, and fix some typos test: disable some symlink extraction tests in miri, and fix some typos Oct 6, 2026
@Pr0methean Pr0methean changed the title test: disable some symlink extraction tests in miri, and fix some typos chore: Fix symlink extraction logic, disable some tests in miri, and fix some typos Oct 6, 2026
@Pr0methean Pr0methean changed the title chore: Fix symlink extraction logic, disable some tests in miri, and fix some typos chore: Fix high-level symlink extraction logic, disable some tests in miri, and fix some typos Oct 6, 2026
Comment thread src/read/stream.rs Fixed
Comment thread src/read/stream.rs Fixed
Comment thread src/read/stream.rs Fixed
Comment thread src/read/stream.rs Fixed
@Pr0methean

Copy link
Copy Markdown
Member Author

@Its-Just-Nans Could you please help fix this failing test?

thread 'test_extract_options_recursive_in_folder' (8904) panicked at tests/extract_symlink_options.rs:253:10:
called `Result::unwrap()` on an `Err` value: InvalidArchive("Path escapes the destination directory")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Its-Just-Nans

Copy link
Copy Markdown
Member

@Pr0methean any reason for ExtractRecursiveInFolder to be the default ?

ExtractInFolder would be a safer default no ?

Merged via the queue into master with commit a72b210 Oct 7, 2026
133 of 134 checks passed
@Pr0methean
Pr0methean deleted the fix-nomiri branch October 7, 2026 20:43
yuxi-liu-wired added a commit to yuxi-liu-wired/zip2 that referenced this pull request Oct 7, 2026
They create a temp dir, which miri's isolation does not allow; the endianness job runs the tests under miri since zip-rs#1035, which marked its own file-system tests the same way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants