Skip to content

feat: add search within file and diff viewers - #38

Merged
ziqq merged 1 commit into
mainfrom
ziqq/viewer-search
Oct 23, 2026
Merged

ziqq merged 1 commit into
mainfrom
ziqq/viewer-search

Conversation

@ziqq

@ziqq ziqq commented Oct 23, 2026

Copy link
Copy Markdown
Owner

Ctrl/Cmd+F now searches the complete open file or validated full-file diff, including rows outside the virtual DOM. Matches retain syntax highlighting, show a count and support Enter/Shift+Enter or previous/next navigation with horizontal and vertical reveal. The find field reuses Codetree's sidebar searchbar and SVG icon-button controls, with provider/theme colors and a consistent focus state.

View full takes shortcut priority over inline tabs and keeps its own query and scroll position. Escape closes search before the dialog. Queries survive Unified/Side-by-side switches, include both revisions and count shared context once; they remain in viewer memory and clear when the file changes. Scans debounce, yield and reject stale work, retaining the first 10,000 matches with an explicit + count when more exist.

Validation:

  • npm run verify: 273/273 tests, formatting, lint, static checks, build and ZIP verification passed.
  • Added 20 regressions: 12 viewer/controller cases and eight inline GitHub/GitLab cases covering shortcuts/focus, literal Unicode ranges across syntax spans, virtualized two-axis reveal, layout changes, separate modal ownership, saved tab positions, match limits and cancellation/disposal.
  • All 20 new scenarios fail on pre-feature main (1085f89) through visible behavior assertions, without missing-import failures.
  • Independent read-only review found no actionable issues.
  • Manual browser smoke with production viewer modules and synthetic sources checked both shortcuts, closed Shadow DOM, result navigation, long lines, dialog Escape and light/dark provider palettes. Installed-extension verification on live GitHub/GitLab remains pending.

@github-actions github-actions Bot added documentation Improvements or additions to documentation need test's Issue to be tested labels Oct 23, 2026
@ziqq ziqq self-assigned this Oct 23, 2026
@ziqq
ziqq merged commit 8f6a8da into main Oct 23, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation need test's Issue to be tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant