Skip to content

Split method cloning from the async to sync rules - #168

Merged
virzak merged 2 commits into
masterfrom
refactor/method-cloner
Sep 12, 2026
Merged

Split method cloning from the async to sync rules#168
virzak merged 2 commits into
masterfrom
refactor/method-cloner

Extract a CloningRewriter base from AsyncToSyncRewriter

354fd2c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2026 in 0s

92.26% (+0.07%) compared to 34b24d4

View this Pull Request on Codecov

92.26% (+0.07%) compared to 34b24d4

Details

Codecov Report

❌ Patch coverage is 93.60825% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.26%. Comparing base (34b24d4) to head (354fd2c).

Files with missing lines Patch % Lines
...omp.SyncMethodGenerator/Cloning/CloningRewriter.cs 92.85% 4 Missing and 7 partials ⚠️
...Zomp.SyncMethodGenerator/Cloning/MethodLocation.cs 89.85% 2 Missing and 5 partials ⚠️
...omp.SyncMethodGenerator/Cloning/MethodSignature.cs 73.68% 2 Missing and 3 partials ⚠️
...rc/Zomp.SyncMethodGenerator/AsyncToSyncRewriter.cs 94.64% 0 Missing and 3 partials ⚠️
...rc/Zomp.SyncMethodGenerator/Cloning/CloneTarget.cs 90.47% 1 Missing and 1 partial ⚠️
....SyncMethodGenerator/Cloning/ClonedMethodSource.cs 97.64% 1 Missing and 1 partial ⚠️
...p.SyncMethodGenerator/SyncMethodSourceGenerator.cs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   92.19%   92.26%   +0.07%     
==========================================
  Files          11       15       +4     
  Lines        1652     1706      +54     
  Branches      381      391      +10     
==========================================
+ Hits         1523     1574      +51     
- Misses         45       48       +3     
  Partials       84       84

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov