Repository navigation
Stand in CancellationToken.None for a removed token - #174
Merged
Merged
Conversation
Generated with Claude Code
A catch filter which checks the token has to keep its shape, so the reference is replaced rather than dropped. None is never cancelled, which is what the synchronized method does. Generated with Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 91.67% 91.69% +0.01%
==========================================
Files 6 6
Lines 1273 1276 +3
Branches 306 307 +1
==========================================
+ Hits 1167 1170 +3
Misses 38 38
Partials 68 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A catch filter which checks a removed CancellationToken kept the reference and did not compile (CS0103). The reference now becomes
global::System.Threading.CancellationToken.None, which is never cancelled, so the filter keeps its shape and is always false.Reported from dotnet/SqlClient against 2.0.56.
Generated with Claude Code