Repository navigation
Drop an awaited ConfigureAwait from a call which does not bind - #175
Merged
Merged
Conversation
Generated with Claude Code
A call whose argument another generator supplies cannot bind, since generators do not see each other's output, and the removal ran off the bound symbol. Reported from dotnet/SqlClient, where the argument came from the System.Text.Json generator. Generated with Claude Code
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 91.67% 91.65% -0.02%
==========================================
Files 6 6
Lines 1273 1282 +9
Branches 306 308 +2
==========================================
+ Hits 1167 1175 +8
Misses 38 38
- Partials 68 69 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
await JsonSerializer.DeserializeAsync(stream, Ctx.Default.ListByte, ct).ConfigureAwait(false)kept theConfigureAwaitand did not compile (CS1929). The call cannot bind because its argument comes from another generator's output, and the removal ran off the bound symbol; it now also drops an awaitedConfigureAwaitby its shape, as theAsyncsuffix already is.Reported from dotnet/SqlClient against 2.0.56.
Generated with Claude Code