Repository navigation
Add private Rivet setup and public OIDC PKCE support - #11
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98f0a328e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds owner-only Rivet setup to selfhost, an explicit read-only MCP health probe, and public OIDC clients with PKCE. Setup uses a server-held management credential, exact owner identity, and same-origin writes. Public OIDC preserves confidential clients, verified-domain admission, password login, and account linking.
The coordinated repair binds setup status and handoffs to an independent HTTPS management endpoint, supporting separate phone/MCP ports and private IPv6 while retaining TLS validation, DNS/family pinning, and redirect refusal. Upstream failures keep the owner retry UI usable. MCP candidates intersect compatible catalogs across connections, preserve JSON argument types, classify invocation auth walls, and extract identity from later JSON text blocks. The producer contract is in Rivet #7.
Validation on isolated current-main integration snapshots: format, lint, all 45 package typechecks, route/patch checks, production build, and 13 shard tests pass. The 39-package local run covers 4,208 tests with the public-OIDC file explicitly excluded; the final ordinary run failed five unchanged cloud database/timeout cases. All 510 cloud tests pass separately in a private network namespace, and an earlier complete serial run passed. This is bounded fixture-isolation evidence, not a claim that the ordinary full command was green. The separate hosted public-OIDC suite passes all 16 tests against a fresh Okta emulator instance with PKCE/ledger assertions and verified reset cleanup. Native split-TLS Rivet/browser integration and success/failure teardown checks pass.
Deploy/publish/release workflows remain disabled on this fork; Fork CI is active. Qualify the producer before enabling owner setup. Preserve producer state during rollback. Real phone/account acceptance and deployment remain outside this PR. Keep the PR open and unmerged.