Repository navigation
refactor: build zvec through upstream CMake targets - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the separate zvec ExternalProject build and manually maintained library dependencies with
add_subdirectoryand upstream CMake targets. Preserve whole-archive linking for algorithm and quantizer registration, pass the macOS deployment target to child builds, and remove the obsolete compilation database merge script and its documentation.Validated with a clean macOS arm64 Release build, 60 passing unit tests (one RaBitQ test skipped on this platform), and four compatibility cases using collections created by 0.7.1. Linux and Windows builds await CI. The Windows Electron delay-load mechanism remains intact in source; Electron runtime testing has not been performed.