Repository navigation
fix: a round restore no longer records false stats or plays over recorded rounds - #290
Merged
Merged
Conversation
…ds with its map A disk file above the backend's rows could never restore, because the api raises on a round with no row and answers nothing. Such files are now ignored when choosing the round to hold, which removes from_disk and RoundToHoldAgain. A file can still fill in a row that exists, and offline keeps its disk rounds. A hold no longer comes back for a round whose backup is gone: it ends and the players are told. An open vote is abandoned when its map changes.
… playing over them Ending the hold when its round's backup was gone turned backups on and let the match resume with recorded rounds still ahead of the server. A hold now falls back to the newest round the backend can load. With none left and rounds recorded ahead, the match stays held on NothingToLoad until Restart Map, with players told once and no vote offered. It only ends when nothing is recorded ahead of the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a round could leave false stats behind, lose a real round, or let a restarted server play over rounds the backend had already recorded.
.resetvote is kept if the vote fails, and dropped if it passes, because the restore is undoing it..reset,.pauseand timeouts are also blocked while a load is owed; a passed offline vote turns backups on; the pending result is cleared on every load.https://github.com/DEAFCS/game-server/commit/b974820f