Skip to content

fix: a round restore no longer records false stats or plays over recorded rounds #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepolo merged 7 commits into from
Nov 3, 2026
Merged

fix: a round restore no longer records false stats or plays over recorded rounds #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b741d33
fix: loading a round backup no longer records false stats
lukepolo Nov 2, 2026
2f20bb1
fix: a passed recovery vote keeps the match held until its round is l…
lukepolo Nov 2, 2026
80653a7
fix: a round that ends during a failed restore vote is no longer lost
lukepolo Nov 2, 2026
fa577fb
fix: backups turn back on after a round restore that could not write …
lukepolo Nov 2, 2026
bca120f
fix: a round restore nobody answered stops resending and never outliv…
lukepolo Nov 2, 2026
e473e3f
fix: a restore only offers rounds the backend can load, and a vote en…
lukepolo Nov 2, 2026
f7aca0a
fix: a hold with no backup left keeps recorded rounds safe instead of…
lukepolo Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/counterstrikesharp/src/FiveStack.Commands/Match.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ public void SetMatchState(CCSPlayerController? player, CommandInfo command)
);
return;
}

_gameBackupRounds.AbandonRestore();
}

match?.UpdateMapStatus(status);
Expand Down
4 changes: 2 additions & 2 deletions apps/counterstrikesharp/src/FiveStack.Events/RoundEnd.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public HookResult OnRoundOfficiallyEnded(EventRoundOfficiallyEnded @event, GameE
match.UpdateMapStatus(eMapStatus.Overtime);
}

if (_gameBackupRounds.IsResettingRound())
if (_gameBackupRounds.HoldsRoundResults())
{
_logger.LogInformation("OnRoundOfficiallyEnded skipping capture: restoring round");
return HookResult.Continue;
Expand All @@ -55,7 +55,7 @@ public HookResult OnRoundOfficiallyEnded(EventRoundOfficiallyEnded @event, GameE
[GameEventHandler]
public HookResult OnRoundEnd(EventRoundEnd @event, GameEventInfo info)
{
if (_gameBackupRounds.IsResettingRound())
if (_gameBackupRounds.HoldsRoundResults())
{
_logger.LogInformation(
$"OnRoundEnd ignored (restoring round): message={@event.Message}"
Expand Down
2 changes: 1 addition & 1 deletion apps/counterstrikesharp/src/FiveStack.Events/RoundStart.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public HookResult OnRoundStart(EventRoundStart @event, GameEventInfo info)
return HookResult.Continue;
}

if (_gameBackupRounds.IsResettingRound())
if (_gameBackupRounds.HoldsRoundResults())
{
// A restart can unpause the round the hold paused.
if (_gameBackupRounds.IsHoldingForRestore())
Expand Down
Loading
Loading