Repository navigation
ci: check built textures in module ci and template the art credits - #32
Merged
Merged
Conversation
module-ci.yml runs scripts/build-textures.py --check, with Pillow, when a Module has that script, so the Modules stop hand-copying the job. The template ships NOTICE with the preamble the Modules share and a commented REUSE.toml override stanza for third-party art. Closes #27 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.
The five Modules that use Malcolm Riley's unused-textures art each set up the same plumbing by hand, and the copies have drifted apart. Craftworks and Voidworks have a
build-textures.py --checkthat no CI runs. Fieldworks wraps it in a unittest, Gearworks has its own job, and Wireworks'build-textures.pyruns nowhere either (its own job checks a second, placeholder script) and it has no NOTICE.What changes
module-ci.ymlgets atexturesjob. If the Module hasscripts/build-textures.py, the job installs Pillow and runspython3 scripts/build-textures.py --check. If it doesn't, the job skips those steps, which includes libworks' own CI.NOTICE: the preamble the existing NOTICEs share word for word, with no entries.REUSE.tomlcovers it as MIT, andfill-template.shkeeps it in new Modules.REUSE.toml: a commented-out override example for third-party art, showing both forms: unmodified copies (includingdata/art/) and textures the script builds from them. It has to stay commented out: an active CC-BY-4.0 stanza needsLICENSES/CC-BY-4.0.txt, andreuse lintfails on that licence while no file uses it.docs/plugin.md,README.md, and an Unreleased entry inCHANGELOG.md.Modules call
module-ci.ymlat aplugin-vtag, so they get the job only with the next plugin release. Carrying the change out to the Modules (dropping Gearworks' and Fieldworks' own jobs, giving Wireworks a NOTICE) is fortemplate-driftafter that release.Testing
test_fill_templatecase checks that a filled Module keeps NOTICE, with no entries, and covered inREUSE.toml. It failed before the change.python3 -m unittest discover scripts/tests: 66 tests pass.reuse lintpasses.pip install pillowstep successfully.The change is CI config, licensing metadata and docs, which CLAUDE.md exempts from
/code-review.🤖 Generated with Claude Code