Repository navigation
feat: ship a gallery pack with a working scene of each feature - #28
Merged
Merged
Conversation
Pipeworks Gallery, off by default, builds nine scenes in rows of three, each with a sign that rebuilds it when clicked. Its game tests run libworks' GalleryCheck a row at a time, and check the Outlet scene's water and a sign's replay. Takes libworks-runtime 0.1.9 for GalleryPack. Closes #26 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…scene's tank visibly Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tank level sign Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…scene The gallery tests build on the same plots, so in one batch the full build's clear wiped the Outlet scene before its water came. Each now runs alone, as Voidworks' do. Adds a test that the Pump scene leaves its water and takes its lava, and tidies GalleryTests from review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The runner's clear sets blocks with no removal, which left the build test's pipes and tanks in the saved segments, so the Pump scene's lava run joined their water and its Pump never took the lava. Also checks the water Pump fills its tank, and tidies the tests from review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Gallery pack, Pipeworks Gallery: a datapack in the jar, off by default, with a working scene of each README feature (libworks ADR 0010).
Scenes use water and lava, since Pipeworks registers no fluid. Every source is walled in glass, and the clear fills
structure_voidbefore air, so no fluid survives a rebuild. Rows of three, not one row: this follows 5thlayer/factoryworks#691's dev-client findings, so pumps stay within simulation distance.GalleryCheck.buildslays one row only, so the test calls its parts per row (5thlayer/libworks#31 to fold rows in).The README also says tanks that touch share their contents. Rendering them as one is #27.
Evidence
/function pipeworks:gallery/buildis unknown.After:
runGameTestServerpasses in full, including:gallery_builds_a_scene_of_each_feature: the pack is offered and off, the build runs with no failing command, and each scene's key block stands.gallery_outlet_scene_sets_its_water_down: the Pump fills the run, and the Outlet sets a water source in its basin.gallery_scenes_sign_clicked_builds_the_scene_again: clicking a sign rebuilds the scene and leaves nothing loose.Merge Danger
Door: two-way
Blast Radius: small
The pack is off unless a player turns it on, and it adds no recipes, loot or worldgen. The nested libworks-runtime moves to 0.1.9, which every Module nesting it gets through FML's newest-in-range pick.
Closes #26
🤖 Generated with Claude Code