Repository navigation
feat: place the void well in one step from its core with groundworks - #96
Merged
Merged
Conversation
The Well's shape ships as a Groundworks Assembly, data only, its core a Key; a JUnit test keeps it equal to WellStructure.layout. The dev client runs Groundworks 0.5.12; the Module names none of its types. Closes #65 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Groundworks present, a Void Well is placed in one step from its core: the preview shows the whole Well, and one click places core, 56 casing and 16 rim around the open shaft, paid from the inventory, the core facing out of its wall. Without Groundworks nothing changes.
data/voidworks/groundworks/assembly/void_well.jsondeclares the Assembly;data/groundworks/tags/block/assembly_keys.jsonmakes the core its Key. Data only: no code names a Groundworks type.WellAssemblyTestreads the shipped JSON as Groundworks does (0.5.12's frame) and asserts it equalsWellStructure.layoutfor every horizontal facing, so drift failsgradlew build.clientModsentry.Checked in game: placing from the core makes a whole, running Well.
gradlew buildandrunGameTestServerpass;/code-reviewrun.Closes #65
🤖 Generated with Claude Code