Repository navigation
Fix exact visual thresholds and expand automation coverage - #88
Merged
Merged
Conversation
adamXbot
force-pushed
the
fix/automation-test-coverage
branch
from
October 30, 2026 05:25
0a462e9 to
f21bf76
Compare
adamXbot
force-pushed
the
fix/review-round-two
branch
from
October 30, 2026 05:25
1ebe0c9 to
4e3ffba
Compare
adamXbot
force-pushed
the
fix/automation-test-coverage
branch
2 times, most recently
from
October 30, 2026 06:11
c087631 to
e05e200
Compare
Replay the automation coverage changes on the updated review branch, retaining its targeted antialiasing filter and default canvas settings.
Use currentWindowGlobal.drawSnapshot at native resolution and await settled frames. Release every bitmap, including on draw failures. Keep the default canvas context restored by the base branch; do not reintroduce its withdrawn software-canvas workaround. Resolves the overlapping dialog capture edits with fix/review-round-two while retaining the base comparison changes. Validation: 593 tests passed, one skipped; 40 focused checks passed with Pillow 10.1.0. The single-pixel and thin-border regression tests still pass. Live rendering requires CI confirmation.
adamXbot
force-pushed
the
fix/automation-test-coverage
branch
from
October 30, 2026 10:37
e05e200 to
37eb2a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the automation gaps found while reviewing #85. A changed pixel on a large capture could round to
0.0000%and pass a zero-change limit; checks now compare exact pixel counts. Generated previews now run for dependency changes anywhere in a theme repository.checkagainst bothshotruns, plusshotagainstshot), report pixel counts, and upload original screenshots on failure. The checks use the shared comparison noise rules without adding a percentage allowance.customChrome.cssin preview/watch mode, and cleanup of all recorded Windows process IDs.Validation
e05e200. The replay onto currentmainpreserves that source tree exactly; GitHub will rerun checks for the new commit IDs.Based on current
main, which includes #85. No merge or release is performed by this PR.