Skip to content

test: port the dms-api inventory journeys off dms-control - #152

Merged
Upd4ting merged 19 commits into
mainfrom
test/wdf26acfc-84-port-inventory
Nov 19, 2026
Merged

Upd4ting merged 19 commits into
mainfrom
test/wdf26acfc-84-port-inventory

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Wdf26acfc-84

Why

dms-control and the DMS verify harness go away once nothing runs through them. This pull request moves every line of the dms-api section of dms e2e/INVENTORY.md that was not yet at its destination, so dms-api's CI runs all of them with no dms-control call: the HTTP and command-line journeys as ordinary Vitest integration tests, the browser journeys in the Playwright suite through the @antelopejs/dms/e2e kit that dms#1162 freed from dms-control.

Summary

  • Integration tests. 31 journeys now run as tests/<feature>.journeys.test.ts under vitest.journeys.config.ts (pnpm test:journeys). Each test gets a backend of the verification playground (ajs project dev) on a fresh database of one shared in-memory MongoDB, with its administrator onboarded (tests/helpers/dms.ts, backend.ts, seed.ts). A test restarts its backend under other module options or environment, which the kit's startRun cannot do. The unit config excludes them.
  • Duplicates. The three package journeys ran the same checks as tests/package.test.ts; they are deleted. e2e/journeys/package.mjs, capture.mjs and automation.mjs stay as empty modules because dms-control map, which tests/package.test.ts runs, wants one per feature file.
  • Kind fixed. The five overview verdict lines were listed as HTTP but read the verdict in the Overview's hero, in a tab. They stay in Playwright, which already runs them.
  • Harness step. pnpm e2e:build runs the five prepare commands of the verify skill. The e2e job runs it and sets DMS_E2E_PREBUILT=1, so the kit's global setup only starts the run. The new journeys job runs pnpm e2e:build then pnpm test:journeys, and the ubuntu gate requires it.
  • Kit. @antelopejs/dms is pinned to 0.21.4-next.939.g641c7fa (dms#1162), and @antelopejs/core to ~1.24.5, its peer range.
  • @smoke. every-console-route-needs-a-session-and-the-block-it-serves and a-request-is-captured-with-its-facts left the Playwright suite. a-member-without-the-modules-permissions-is-sent-to-their-settings and a-request-opens-in-a-drawer-that-steps-through-the-list take their places: 7 @smoke journeys before and after.
  • Dead helpers. recordRaw, sendAndRead, seedStatistics and dayStart of e2e/ had only ported callers left.
flowchart LR
  subgraph before
    P1[pnpm e2e] --> K1[kit global setup: dms-control up --prepare]
    K1 --> J1[85 journeys, browser, HTTP and command line]
  end
  subgraph after
    B[pnpm e2e:build] --> P2[pnpm e2e, DMS_E2E_PREBUILT=1]
    P2 --> K2[kit global setup: startRun] --> J2[51 browser journeys]
    B --> V[pnpm test:journeys] --> M[(one mongod)]
    V --> D[a playground backend per test] --> M
  end
Loading

Inventory lines

Counts of the 76 lines of the dms-api section:

Status Before After
green in CI 36 73
todo 40 0
deleted: duplicate 0 3
# Feature Line Kind Destination Status before Status after
1 access every-console-route-needs-a-session-and-the-block-it-serves HTTP integration tests/access.journeys.test.ts todo green in CI: QUEUE_RUN
2 access the-console-is-the-owners-and-a-role-holding-a-block-is-refused HTTP integration tests/access.journeys.test.ts todo green in CI: QUEUE_RUN
3 automation without-the-automation-module-the-registration-is-a-silent-no-op HTTP integration tests/automation.journeys.test.ts todo green in CI: QUEUE_RUN
4 automation the-module-registers-its-three-nodes-with-their-documented-inputs HTTP integration tests/automation.journeys.test.ts todo green in CI: QUEUE_RUN
5 automation get-api-health-restricts-its-breakdown-to-the-last-days command line integration tests/automation.journeys.test.ts todo green in CI: QUEUE_RUN
6 automation query-request-logs-pages-caps-and-filters command line integration tests/automation.journeys.test.ts todo green in CI: QUEUE_RUN
7 automation route-unhealthy-fires-on-the-flags-it-watches-and-never-faster-than-ten-seconds HTTP integration tests/automation.journeys.test.ts todo green in CI: QUEUE_RUN
8 automation query-request-logs-next-cursor-reads-the-next-page command line integration tests/automation.journeys.test.ts todo green in CI: QUEUE_RUN (test.fails: the action takes no cursor input)
9 capture a-request-is-captured-with-its-facts HTTP integration tests/capture.journeys.test.ts todo green in CI: QUEUE_RUN
10 capture a-thrown-error-keeps-its-message-and-its-stack HTTP integration tests/capture.journeys.test.ts todo green in CI: QUEUE_RUN
11 capture the-consoles-own-and-the-dms-traffic-is-never-captured HTTP integration tests/capture.journeys.test.ts todo green in CI: QUEUE_RUN
12 capture only-the-listed-headers-are-stored-and-secret-ones-never HTTP integration tests/capture-redaction.journeys.test.ts todo green in CI: QUEUE_RUN
13 capture values-under-secret-looking-keys-are-redacted-before-storage HTTP integration tests/capture-redaction.journeys.test.ts todo green in CI: QUEUE_RUN
14 capture bodies-above-the-cap-are-stored-truncated-and-flagged HTTP integration tests/capture-redaction.journeys.test.ts todo green in CI: QUEUE_RUN
15 capture a-key-is-secret-by-the-words-it-is-made-of HTTP integration tests/capture-redaction.journeys.test.ts todo green in CI: QUEUE_RUN
16 capture secrets-and-card-numbers-are-redacted-wherever-they-sit HTTP integration tests/capture-redaction.journeys.test.ts todo green in CI: QUEUE_RUN
17 logs the-tabs-the-filters-and-the-search-narrow-the-list browser Playwright green in CI green in CI: QUEUE_RUN
18 logs the-list-is-newest-first-sorts-and-pages HTTP integration tests/logs.journeys.test.ts todo green in CI: QUEUE_RUN
19 logs pause-holds-the-table-and-counts-what-was-missed browser Playwright green in CI green in CI: QUEUE_RUN
20 logs the-histogram-bars-follow-the-period browser Playwright green in CI green in CI: QUEUE_RUN
21 logs a-request-opens-in-a-drawer-that-steps-through-the-list browser Playwright green in CI green in CI: QUEUE_RUN
22 logs a-link-names-a-range-with-since-and-until browser Playwright green in CI green in CI: QUEUE_RUN
23 logs the-histogram-counts-past-days-by-class HTTP integration tests/logs.journeys.test.ts todo green in CI: QUEUE_RUN
24 logs a-past-range-draws-at-most-120-bars HTTP integration tests/logs.journeys.test.ts todo green in CI: QUEUE_RUN
25 logs filters-combine-with-the-status-tab HTTP integration tests/logs.journeys.test.ts todo green in CI: QUEUE_RUN
26 logs the-list-sorts-by-duration-both-ways browser Playwright green in CI green in CI: QUEUE_RUN
27 logs the-slow-labels-follow-the-threshold-in-seconds-or-milliseconds browser Playwright green in CI green in CI: QUEUE_RUN
28 logs counts-are-grouped-and-all-time-compares-nothing browser Playwright green in CI green in CI: QUEUE_RUN
29 overview with-no-traffic-the-verdict-is-idle browser Playwright green in CI green in CI: QUEUE_RUN
30 overview nineteen-failing-calls-are-too-few-to-judge browser (was HTTP: it reads the hero in a tab) Playwright todo green in CI: QUEUE_RUN
31 overview one-failing-call-in-a-hundred-is-degraded browser (was HTTP: it reads the hero in a tab) Playwright todo green in CI: QUEUE_RUN
32 overview one-failing-call-in-a-hundred-and-one-is-operational browser (was HTTP: it reads the hero in a tab) Playwright todo green in CI: QUEUE_RUN
33 overview a-fifth-of-the-calls-failing-is-down browser (was HTTP: it reads the hero in a tab) Playwright todo green in CI: QUEUE_RUN
34 overview nineteen-percent-failing-is-degraded-not-down browser (was HTTP: it reads the hero in a tab) Playwright todo green in CI: QUEUE_RUN
35 overview the-blocks-rank-the-routes-by-what-is-wrong-with-them browser Playwright green in CI green in CI: QUEUE_RUN
36 overview the-period-and-the-comparison-are-kept-in-the-url-and-shared-by-the-pages browser Playwright green in CI green in CI: QUEUE_RUN
37 overview down-reads-the-last-five-minutes-and-not-the-last-fifteen HTTP integration tests/overview.journeys.test.ts todo green in CI: QUEUE_RUN
38 overview errors-older-than-five-minutes-do-not-make-the-api-down HTTP integration tests/overview.journeys.test.ts todo green in CI: QUEUE_RUN
39 overview the-module-path-redirects-to-the-overview browser Playwright green in CI green in CI: QUEUE_RUN
40 overview a-route-is-flagged-at-the-documented-edges-whatever-the-period browser Playwright green in CI green in CI: QUEUE_RUN
41 overview a-comparison-beyond-the-kept-statistics-compares-with-nothing browser Playwright green in CI green in CI: QUEUE_RUN
42 overview the-hero-says-how-long-the-verdict-has-held-and-when-it-was-checked browser Playwright green in CI green in CI: QUEUE_RUN
43 overview a-comparison-the-page-does-not-know-compares-with-nothing HTTP integration tests/overview.journeys.test.ts todo green in CI: QUEUE_RUN
44 overview every-figure-compared-with-the-period-before-says-its-change-and-its-value browser Playwright green in CI green in CI: QUEUE_RUN
45 overview the-slowest-routes-are-ranked-by-average-latency-not-by-their-slowest-call browser Playwright green in CI green in CI: QUEUE_RUN
46 package the-tarball-holds-what-the-manifest-names command line none todo deleted: duplicate of tests/package.test.ts › the packed tarball
47 package the-ranges-and-the-skill-match-what-the-docs-name command line none todo deleted: duplicate of tests/package.test.ts › the ranges the docs name, the skill
48 package the-docs-links-and-the-two-locales-are-complete command line none todo deleted: duplicate of tests/package.test.ts › the docs and the locales
49 retention lowering-a-retention-tells-what-the-next-prune-deletes HTTP integration tests/retention.journeys.test.ts todo green in CI: QUEUE_RUN
50 retention the-hourly-prune-deletes-what-the-retention-passed HTTP integration tests/retention.journeys.test.ts todo green in CI: QUEUE_RUN
51 retention lowering-a-retention-asks-before-it-deletes browser Playwright green in CI green in CI: QUEUE_RUN
52 routes the-tree-groups-routes-by-folder-and-the-filters-narrow-it browser Playwright green in CI green in CI: QUEUE_RUN
53 routes a-route-opens-with-its-header-and-the-url-names-it browser Playwright green in CI green in CI: QUEUE_RUN
54 routes the-statistics-tab-adds-up-the-period browser Playwright green in CI green in CI: QUEUE_RUN
55 routes the-documentation-tab-is-inferred-from-the-code-and-the-traffic browser Playwright green in CI green in CI: QUEUE_RUN
56 routes authentication-is-read-from-the-guards-before-the-handler browser Playwright green in CI green in CI: QUEUE_RUN
57 routes the-contract-reads-seven-days-of-real-calls-and-never-the-testers HTTP integration tests/routes.journeys.test.ts todo green in CI: QUEUE_RUN
58 routes a-route-from-an-installed-module-names-its-module browser Playwright green in CI green in CI: QUEUE_RUN
59 routes the-route-statistics-compare-in-points-with-the-period-before browser Playwright green in CI green in CI: QUEUE_RUN
60 routes the-documentation-writes-its-snippets-against-the-public-api-origin-and-hides-what-was-never-called browser Playwright green in CI green in CI: QUEUE_RUN
61 settings the-form-shows-the-documented-defaults browser Playwright green in CI green in CI: QUEUE_RUN
62 settings every-bound-of-the-form-is-enforced-on-its-edge HTTP integration tests/settings.journeys.test.ts todo green in CI: QUEUE_RUN
63 settings use-default-returns-a-field-to-the-module-option HTTP integration tests/settings.journeys.test.ts todo green in CI: QUEUE_RUN
64 settings the-module-refuses-to-start-with-a-value-the-form-would-refuse command line integration tests/settings.journeys.test.ts todo green in CI: QUEUE_RUN
65 settings the-scope-decides-which-routes-and-requests-every-page-watches browser Playwright green in CI green in CI: QUEUE_RUN
66 settings a-log-retention-of-no-day-is-refused-at-start HTTP integration tests/settings.journeys.test.ts todo green in CI: QUEUE_RUN
67 settings retention-fields-have-no-use-default-but-the-others-do browser Playwright green in CI green in CI: QUEUE_RUN
68 smoke traffic-shows-in-the-overview-and-the-request-logs browser Playwright green in CI green in CI: QUEUE_RUN
69 tester a-tester-call-is-logged-and-marked-but-never-counted browser Playwright green in CI green in CI: QUEUE_RUN
70 tester a-secret-keeps-the-testers-token-valid-across-restarts HTTP integration tests/tester.journeys.test.ts todo green in CI: QUEUE_RUN
71 tester the-tester-sends-the-form-and-keeps-twenty-five-calls browser Playwright green in CI green in CI: QUEUE_RUN
72 tester a-history-entry-restores-its-call-and-a-typed-authorization-beats-the-session browser Playwright green in CI green in CI: QUEUE_RUN
73 tester headers-for-all-routes-are-kept-in-the-browser-but-credentials-are-not browser Playwright green in CI green in CI: QUEUE_RUN
74 tester a-replayed-call-needs-its-credentials-and-redacted-values-by-hand browser Playwright green in CI green in CI: QUEUE_RUN
75 formal formal-route-statistics command line CI job formal-route-statistics green in CI green in CI: QUEUE_RUN
76 harness prepare of verify-dms-api (5 commands) command line pnpm e2e:build in the e2e and journeys jobs, DMS_E2E_PREBUILT=1 for the kit todo green in CI: QUEUE_RUN

Proof

Journey integration tests, locally, 4 workers: 10 files, 31 tests passed in 63 s (pnpm test:journeys --maxWorkers=4). The Playwright list goes from 85 journeys on main to 51 (pnpm exec playwright test -c e2e --list).

Each file fails on a wrong implementation. One line of src/ broken, pnpm build, the test run, then reverted:

Test Break Output with the break Output reverted
capture › a-request-is-captured-with-its-facts requestId: undefined in capture.ts the stored request: expected { …(33) } to match object … + "requestId": null ✓ 1 passed
capture › a-key-is-secret-by-the-words-it-is-made-of pin matched anywhere in redaction.ts spin keeps its value, pinned keeps its value fail passed
access › every-console-route-needs-… GET /logs guarded by LogsPage.live GET /logs refuses with its own block's permission fails passed
tester › a-secret-keeps-the-testers-token-valid-across-restarts signingKey() ignores testerSourceSecret under the same secret the call is the Tester's: expected null to be 'tester' passed
routes › the-contract-reads-seven-days-… CONTRACT_WINDOW_DAYS 7 → 9 totals 3 not 2, legacy field, [[201,3]] passed
logs › a-past-range-draws-at-most-120-bars TARGET_MAX_BARS 120 → 240 3 to 2 days ago: 50 to 120 bars (145) passed
overview › down-reads-the-last-five-minutes-… downWindowMinutes 5 → 15 the verdict: expected 'degraded' to be 'down' passed
settings › every-bound-of-the-form-… logRetentionDays max 366 → 400 requestLogRetentionDays = 367: expected 200 to be 400 passed
automation › query-request-logs-pages-caps-and-filters REQUEST_LOG_MAX_LIMIT 200 → 300 expected [ 250, true ] to deeply equal [ 200, true ] passed
retention › the-hourly-prune-… hourly pruneRequestLogs dropped expected [ Array(10) ] to deeply equal [ +0, 10, 10, 10, 10 ] passed

Known failure

automation › query-request-logs-next-cursor-reads-the-next-page is test.fails. Run as a plain test it fails on api.query-request-logs returns a nextCursor but takes no cursor input, so a second call returns the first page again: expected false to be true.

Follow-ups

  • proposed AntelopeJS/dms-api: api.query-request-logs returns a nextCursor but takes no cursor input, done means a call with it returns the next page and the test.fails of query-request-logs-next-cursor-reads-the-next-page becomes a test.
  • proposed AntelopeJS/dms-api: the journey tests and the kit start the playground under .agents/skills/verify-dms-api/playground, and tests/package.test.ts runs dms-control map, done means both work once the verify skill folder and dms-control are deleted.
  • proposed AntelopeJS/dms: startRun of @antelopejs/dms/e2e/run cannot restart a backend with other environment, so HTTP journeys that restart need a harness of their own, done means it exposes a restart with extra environment.
  • proposed AntelopeJS/dms-api: a backend stopped with SIGTERM can log [ERROR] [dms-api] route statistics write failed: MongoClientClosedError: Operation interrupted because client was closed (seen in CI run 44492434790, job journeys), done means the module flushes its statistics before the database client closes and a stop logs no error.

@Upd4ting
Upd4ting marked this pull request as ready for review November 19, 2026 09:00
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 38d44c9 Nov 19, 2026
14 checks passed
@Upd4ting
Upd4ting deleted the test/wdf26acfc-84-port-inventory branch November 19, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant