Repository navigation
test: run the e2e kit and the journeys off the verify skill folder - #153
Merged
Merged
Conversation
Upd4ting
marked this pull request as ready for review
November 19, 2026 12:00
Upd4ting
enabled auto-merge
November 19, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Wdf26acfc-103.
Why
Decision 13 deletes
dms-controland the verify harness. Today the green suites of this repo still need both at run time. The e2e kit andtests/helpers/backend.tsstart the playground in.agents/skills/verify-dms-api/playground, andtests/package.test.tsrunsdms-control map. This PR makes CI pass without either, so the later deletion is a folder removal.Summary
@antelopejs/dmsis pinned to0.21.4-next.944.g3da5606, whose e2e kit readse2e/journeys.config.ts(supported since0.21.4-next.943.gd7a4ed8).e2e/journeys.config.tsdeclares the playground, the prepare commands (pnpm install, thenpnpm run e2e:build, so the commands live in one place) and the smoke feature.e2eConfig()names no skill, so the kit reads this file..agents/skills/verify-dms-api/playgroundtoe2e/playground. The files are byte-identical renames, except two relative paths inantelope.config.ts(moduleRoot) and thenode_moduleslink.e2e:build,tests/helpers/backend.ts,tests/helpers/journeys-setup.ts,.gitignoreand the skill'sverify.config.tspoint at the new location, so the skill keeps working until it is deleted.e2e/playground/tsconfig.jsonis new. The type-aware lint now covers the playground, which it skipped under.agents/, and lints it clean. oxfmt leaves it hand-formatted like the journeys.dms-control maptest is replaced bythe e2e journeystest intests/package.test.ts. It imports everye2e/journeys/*.mjs, checks that each exports ajourneyslist, and checks that the config's smoke feature has journeys. Thecovers:globs and docs links thatmapalso checked are metadata of the skill'sfeatures/*.mdand are deleted with the skill. The kit already refuses a repeated journey id when thee2ejob collects the suite.sendAndReadintests/helpers/dms.tsnow reads only a log written after its call. Capture is asynchronous, so after back-to-back calls on one route it could return the previous call's log. CI run 44519937724 failedcapture > secrets-and-card-numbers-are-redacted-wherever-they-sitthat way: the bare-string call read the malformed call'srequestBodyOmitted: "malformed". The race predates this PR.e2e/journeys/{automation,capture,package}.mjskeep their empty lists. The skill'sdms-control mapstill wants one module per feature file until the skill is deleted.flowchart LR subgraph before K1[e2e kit] -->|reads| V[.agents/skills/verify-dms-api/verify.config.ts] V --> P1[.agents/skills/verify-dms-api/playground] J1[test:journeys] --> P1 T1[package.test.ts] -->|spawns| M[dms-control map] M --> V end subgraph after K2[e2e kit] -->|reads| C[e2e/journeys.config.ts] C --> P2[e2e/playground] J2[test:journeys] --> P2 T2[package.test.ts] -->|imports| E[e2e/journeys/*.mjs] endProof
Each run moved
.agents/skills/verify-dms-apiout of the checkout and movednode_modules/.bin/dms-controlaway, sopnpm exec dms-controlresolves to nothing.TZ=UTC, andDMS_E2E_PREBUILTwas unset, so the kit ran the new config'spreparetoo.Before, on
origin/main(38d44c9) with the folder moved away:The journeys and the e2e kit fail on
mainthe same way: both start a playground that is no longer there.After, on
a73b105with the folder and the binary moved away:The new test fails when the smoke feature exports no journeys (
smoke.mjsset toguarded([])):The merge queue runs every journey in two shards.
What still references the folder
git grepoutside.agents/skills/verify-dms-api, agent-facing text and names only:AGENTS.md:40links the verification skill.antelopejs-syncgenerates that line from the folder's presence, so the deletion commit must also carry the regeneratedAGENTS.md, orsync:checkreports drift..claude/skills/verify-dms-apiis a symlink to the skill folder and becomes dangling. The deletion commit should remove it..agents/skills/formal-route-statistics/SKILL.md:42describes how the verify skill runs the formal check..gitignore:375keeps.agents/skills/verify-dms-api/coveragetracked.CHANGELOG.md:97is history.e2e/playground/antelope.config.ts(name: "verify-dms-api") ande2e/playground/package.json(verify-dms-api-app) are names, not paths..github/workflows/ci.ymlcaches~/.cache/dms-control/frontendand setsDMS_CONTROL_RUNS. These are the e2e kit's own cache and run folders, not the binary.Follow-ups