Skip to content

test: run the e2e kit and the journeys off the verify skill folder - #153

Merged
Upd4ting merged 5 commits into
mainfrom
test/wdf26acfc-103-off-verify-harness
Nov 19, 2026
Merged

Upd4ting merged 5 commits into
mainfrom
test/wdf26acfc-103-off-verify-harness

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Task Wdf26acfc-103.

Why

Decision 13 deletes dms-control and the verify harness. Today the green suites of this repo still need both at run time. The e2e kit and tests/helpers/backend.ts start the playground in .agents/skills/verify-dms-api/playground, and tests/package.test.ts runs dms-control map. This PR makes CI pass without either, so the later deletion is a folder removal.

Summary

  • @antelopejs/dms is pinned to 0.21.4-next.944.g3da5606, whose e2e kit reads e2e/journeys.config.ts (supported since 0.21.4-next.943.gd7a4ed8).
  • e2e/journeys.config.ts declares the playground, the prepare commands (pnpm install, then pnpm run e2e:build, so the commands live in one place) and the smoke feature. e2eConfig() names no skill, so the kit reads this file.
  • The fixture playground moves from .agents/skills/verify-dms-api/playground to e2e/playground. The files are byte-identical renames, except two relative paths in antelope.config.ts (moduleRoot) and the node_modules link. e2e:build, tests/helpers/backend.ts, tests/helpers/journeys-setup.ts, .gitignore and the skill's verify.config.ts point at the new location, so the skill keeps working until it is deleted.
  • e2e/playground/tsconfig.json is new. The type-aware lint now covers the playground, which it skipped under .agents/, and lints it clean. oxfmt leaves it hand-formatted like the journeys.
  • The dms-control map test is replaced by the e2e journeys test in tests/package.test.ts. It imports every e2e/journeys/*.mjs, checks that each exports a journeys list, and checks that the config's smoke feature has journeys. The covers: globs and docs links that map also checked are metadata of the skill's features/*.md and are deleted with the skill. The kit already refuses a repeated journey id when the e2e job collects the suite.
  • sendAndRead in tests/helpers/dms.ts now reads only a log written after its call. Capture is asynchronous, so after back-to-back calls on one route it could return the previous call's log. CI run 44519937724 failed capture > secrets-and-card-numbers-are-redacted-wherever-they-sit that way: the bare-string call read the malformed call's requestBodyOmitted: "malformed". The race predates this PR.
  • e2e/journeys/{automation,capture,package}.mjs keep their empty lists. The skill's dms-control map still wants one module per feature file until the skill is deleted.
flowchart LR
  subgraph before
    K1[e2e kit] -->|reads| V[.agents/skills/verify-dms-api/verify.config.ts]
    V --> P1[.agents/skills/verify-dms-api/playground]
    J1[test:journeys] --> P1
    T1[package.test.ts] -->|spawns| M[dms-control map]
    M --> V
  end
  subgraph after
    K2[e2e kit] -->|reads| C[e2e/journeys.config.ts]
    C --> P2[e2e/playground]
    J2[test:journeys] --> P2
    T2[package.test.ts] -->|imports| E[e2e/journeys/*.mjs]
  end
Loading

Proof

Each run moved .agents/skills/verify-dms-api out of the checkout and moved node_modules/.bin/dms-control away, so pnpm exec dms-control resolves to nothing. TZ=UTC, and DMS_E2E_PREBUILT was unset, so the kit ran the new config's prepare too.

Before, on origin/main (38d44c9) with the folder moved away:

$ pnpm exec vitest run tests/package.test.ts -t "feature map"
 FAIL  tests/package.test.ts > the verify feature map > covers every user-facing file, and every feature has its journeys
"Error: Command failed: pnpm exec dms-control map
dms-control: Expected one .agents/skills/verify-*/verify.config.ts under …, found 0; pass --skill <dir>.
      Tests  1 failed | 9 skipped (10)

The journeys and the e2e kit fail on main the same way: both start a playground that is no longer there.

After, on a73b105 with the folder and the binary moved away:

$ ls .agents/skills
formal-route-statistics
technical-writing
unslop
$ command -v dms-control || pnpm exec dms-control --help || echo "dms-control: not found"
dms-control: not found
$ pnpm exec vitest run --maxWorkers 4
 Test Files  35 passed (35)
      Tests  351 passed (351)
$ pnpm e2e:build
exit 0
$ pnpm test:journeys
 Test Files  10 passed (10)
      Tests  31 passed (31)
$ pnpm e2e --grep @smoke --workers 1
  7 passed (1.6m)

The new test fails when the smoke feature exports no journeys (smoke.mjs set to guarded([])):

AssertionError: expected 0 to be greater than 0
      Tests  1 failed | 9 skipped (10)

The merge queue runs every journey in two shards.

What still references the folder

git grep outside .agents/skills/verify-dms-api, agent-facing text and names only:

  • AGENTS.md:40 links the verification skill. antelopejs-sync generates that line from the folder's presence, so the deletion commit must also carry the regenerated AGENTS.md, or sync:check reports drift.
  • .claude/skills/verify-dms-api is a symlink to the skill folder and becomes dangling. The deletion commit should remove it.
  • .agents/skills/formal-route-statistics/SKILL.md:42 describes how the verify skill runs the formal check.
  • .gitignore:375 keeps .agents/skills/verify-dms-api/coverage tracked.
  • CHANGELOG.md:97 is history.
  • e2e/playground/antelope.config.ts (name: "verify-dms-api") and e2e/playground/package.json (verify-dms-api-app) are names, not paths.
  • .github/workflows/ci.yml caches ~/.cache/dms-control/frontend and sets DMS_CONTROL_RUNS. These are the e2e kit's own cache and run folders, not the binary.

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 19, 2026 12:00
@Upd4ting
Upd4ting enabled auto-merge November 19, 2026 12:03
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit d63978b Nov 19, 2026
14 checks passed
@Upd4ting
Upd4ting deleted the test/wdf26acfc-103-off-verify-harness branch November 19, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant