Skip to content

test(e2e): cover the verify skill's undriven flows and run the suite in the merge queue - #217

Merged
Upd4ting merged 14 commits into
mainfrom
test/wdf26acfc-19-e2e-flows
Nov 19, 2026
Merged

Upd4ting merged 14 commits into
mainfrom
test/wdf26acfc-19-e2e-flows

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Why

Wdf26acfc-19. Every browser test of dms-database belongs in its Playwright suite (playwright test -c e2e). Pull requests run the @smoke set, and the merge queue runs every journey. Two gaps remained. The verify skill still listed main user flows as "Not driven". And the checks dms-control ran outside a browser had stopped running once the journeys left the skill: dms-control map and the npm pack, locale and range checks.

What changed

  • CI (ci.yml). select outputs e2e (none, smoke or all) and shards:

    Event e2e job
    pull request, not a draft --grep @smoke, 1 runner
    pull request labelled ci:full, merge_group, workflow_dispatch, push, nightly every journey, 2 shards, merged by e2e-report
    draft, or a docs-only pull request into next none

    The ubuntu gate requires e2e whenever select asks for it. The on: triggers belong to antelopejs-sync: the move to @antelopejs/tooling-configs 0.8.9 brings merge_group, the labeled type and the push to main, and drops next-sync.yml and stale.yml. Before, pull requests to main and manual runs ran @smoke, the nightly ran every journey, and a pull request into next ran nothing.

  • Stack (e2e/stack.ts, e2e/ctx.ts). A journey can stop and restart MongoDB (ctx.stopDatabase, ctx.startDatabase) and write its database directly (ctx.database). A reset restarts a stopped replica set, so a failed journey leaves the next one a running database.

  • 6 new journeys for flows the feature map listed as not driven (table below).

  • 5 stale journeys updated. They had failed on main's nightly since feat(database): promote next to stable #216, because the product and docs changed and the journeys did not. A number contains filter now compares the whole value (docs/4.usage/4.data-browser.md:16). An external database now gets a Diagram (docs/4.usage/6.external-databases.md:40-42). The search skips list columns. No product code changed.

  • Non-browser checks become mocha tests in pnpm test.

    • src/test/package.test.ts replaces the 3 package journeys. It lists the tarball with npm pack --dry-run --json, so it also runs on Windows, and checks the locales and the README ranges.
    • src/test/feature-map.test.ts does what dms-control map checked: every user-facing file maps to a feature, every docs page exists, and every journey is named in a feature file. On its first run it found 12 unmapped files and 1 undocumented journey. Both are fixed in the feature files.
  • The verify skill's SKILL.md, the feature files and AGENTS.md describe the new state.

Proof

Verify feature-map flows and the spec that covers each

Each new journey passed --repeat-each 3 locally, and the Overview one passed 5 of 5.

Flow (verify skill, formerly "Not driven") Spec Journey
Overview: unreachable database, Unavailable, Last error, Check again specs/overview.spec.ts an-unreachable-database-shows-unavailable-and-check-again-recovers
History: Today, Yesterday and older day groups specs/library.spec.ts history-groups-runs-by-day-with-yesterday-and-older-dates
History: a row written before runs recorded a status reads as ok specs/library.spec.ts a-history-row-without-a-status-reads-as-ok
Editing: the undo's own write fails specs/editing.spec.ts an-undo-whose-write-fails-keeps-the-saved-values-and-offers-undo-again
Diagram: Esc leaves the find field, then the focus, then the selection specs/diagram.spec.ts escape-leaves-the-find-field-then-lifts-the-focus-then-clears-the-selection
/modules/database/query?schema=&table= opens the console on the table, per instance specs/query.spec.ts a-link-opens-the-console-on-the-table-in-the-instance-it-names
Query console: column completion, Format, Chart view, Open in data browser specs/query.spec.ts already driven since #198 (ctrl-space-inside-a-filter-completes-the-columns-of-the-table, format-strips-trailing-spaces-and-blank-lines, the-chart-plots-the-first-numeric-column-with-pickers-for-both-axes, open-in-data-browser-opens-the-target-table-or-the-row); only SKILL.md was stale

Still not driven, with the reason in SKILL.md: the table watch on a standalone MongoDB, the empty schema-cards state, the diagram's name order (vitest covers it), the extension boundary and the role editor.

One known failure, a product finding: with MongoDB down, GET /api/database/health answers 500 after the driver's 30 s server selection, not status: down within the 3 s probe deadline. The card still turns Unavailable, 60 to 120 s after the stop.

Integration tests that replace each non-browser check

Check Ran as Now
the tarball holds what its manifest names Playwright journey the-tarball-holds-what-its-manifest-names src/test/package.test.ts, 3 tests
both locales hold the same texts Playwright journey both-locales-hold-the-same-texts src/test/package.test.ts
ranges match the compatibility table Playwright journey ranges-match-the-compatibility-table src/test/package.test.ts
dms-control map: user-facing files covered, docs pages exist dms-control map, broken since #198 src/test/feature-map.test.ts, 4 tests
$ mocha dist/test/feature-map.test.js dist/test/package.test.js
  9 passing (2s)

The formal checks keep their own runners: formal-table-watch has its CI job, and formal-access-write-back is already a test in pnpm test.

Playwright test counts

before (origin/main)   $ playwright test -c e2e --list                 Total: 151 tests in 1 file
                       $ playwright test -c e2e --list --grep @smoke   Total: 5 tests in 1 file
after (this branch)    $ playwright test -c e2e --list                 Total: 154 tests in 1 file
                       $ playwright test -c e2e --list --grep @smoke   Total: 5 tests in 1 file

The change is 151 − 3 package checks moved to mocha + 6 new journeys. The @smoke set is unchanged and fast: smoke, every-route-needs-a-signed-in-session, edits-are-staged-then-reviewed-then-written-one-put-per-row, the-connection-card-reads-the-probe and a-query-returns-its-rows-in-the-order-it-asks.

Whole suite

  • Before: the nightly on main failed in both shards on 17, 18 and 19 Nov, with 5 failing journeys (data ×2, editing ×1, external ×2). A local whole-suite run of this branch before the journey update matched that: 149 passed, 5 failed.
  • After, at 160e541: workflow_dispatch run 44462108755, every job green:
    e2e (1)  Running 77 tests using 1 worker, shard 1 of 2   77 passed (22.2m)
    e2e (2)  Running 77 tests using 1 worker, shard 2 of 2   77 passed (24.2m)
    
    The pull request's own run passed the @smoke e2e job in 2 min 50 s. The new mocha tests ran green in ci / Test .nvmrc.

Scope

  • No product code changes.
  • This repo keeps its own Playwright stack (e2e/stack.ts), the pilot that preceded the @antelopejs/dms/e2e kit. It already runs playwright test -c e2e without dms-control. Moving it onto the kit is a follow-up once the kit drops dms-control.

Follow-ups

  • proposed AntelopeJS/dms-database: with MongoDB down, GET /api/database/health answers 500 after 30 s because getOverviewHealth reads the totals after a failed probe; done means it answers status: down with the probe's error within the 3 s deadline and the journey's knownFailures entry is removed.
  • proposed AntelopeJS/dms-database: the locale key dms_database.data.save.undo_failed is never shown (a failed undo shows undo_partial); done means the key is used for a wholly failed undo or removed from both locales.
  • proposed AntelopeJS/dms-database: the repo has no ci:full label; done means the label exists and labelling a PR runs every journey.
  • proposed AntelopeJS/dms-database: e2e/ runs its own stack, not the @antelopejs/dms/e2e kit; done means the suite registers its journeys through the kit once the kit no longer needs dms-control, with the same 154 tests.

@Upd4ting
Upd4ting marked this pull request as ready for review November 19, 2026 04:51
@Upd4ting
Upd4ting enabled auto-merge November 19, 2026 07:10
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit fa1acbd Nov 19, 2026
12 checks passed
@Upd4ting
Upd4ting deleted the test/wdf26acfc-19-e2e-flows branch November 19, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant