Repository navigation
Fill in placeholders in block validation messages - #5161
Merged
Merged
Conversation
chubes4
marked this pull request as ready for review
October 16, 2026 20:25
Collaborator
📊 Performance Test ResultsComparing 777e460 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
11 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude (via the Pi coding agent in a Roadie session) found this while comparing Studio Code agent runs, traced it to the code, wrote the change and its test, and ran the verification below. Opened as a draft for human review.
Proposed Changes
Expected attribute \%s` of value `%s`, saw `%s`., followed by the values.validate_blocks` joined these pieces as they came, so the agent read the template with its placeholders still in it and the values tacked on afterwards.Before:
After:
Testing Instructions
validate_blockson<!-- wp:heading {"style":{"color":{"text":"#faf8f5"}}} --><h2 class="wp-block-heading" style="color:#faf8f5">Hi</h2><!-- /wp:heading -->. The issue reads like the "After" output above. This was checked against a running site's editor.Pre-merge Checklist