Skip to content

Fill in placeholders in block validation messages #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Oct 16, 2026
Merged

Fill in placeholders in block validation messages #5161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions apps/cli/ai/block-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,18 @@ export async function validateBlocks(
};
}

// Block validation logs console-style messages: a format string whose
// %s / %o / %d placeholders take the arguments that follow it.
function formatIssue( args: any[] ): string {
const show = ( value: any ) =>
typeof value === 'object' ? JSON.stringify( value ) : String( value );
const rest = args.slice( 1 );
const text = String( args[ 0 ] ?? '' ).replace( /%[sodif]/g, ( placeholder ) =>
rest.length ? show( rest.shift() ) : placeholder
);
return [ text, ...rest.map( show ) ].join( ' ' ).slice( 0, 600 );
}

function extractIssues( validationIssues: any[] ): string[] {
const issues: string[] = [];
for ( const issue of validationIssues ) {
Expand All @@ -80,15 +92,7 @@ export async function validateBlocks(
// Skip the verbose "Block validation failed for `name`" summary —
// the per-attribute messages that follow are more useful.
if ( ! msg.startsWith( 'Block validation failed' ) ) {
issues.push(
issue.args
.map( ( a: any ) =>
typeof a === 'object'
? JSON.stringify( a ).slice( 0, 200 )
: String( a ).slice( 0, 500 )
)
.join( ' ' )
);
issues.push( formatIssue( issue.args ) );
}
}
}
Expand Down
Loading