Repository navigation
Take the ROCm SDK version for _rocm_init.py from the build environment - #5
Merged
Merged
Conversation
tools/metadata/dependencies.py pins rocm[libraries] to PYTORCH_ROCM_SDK_VERSION, or to the rocm package installed in the build environment when the variable is unset, but torch/CMakeLists.txt only generated _rocm_init.py from the variable. A build that installs the SDK's rocm package instead of exporting the version got the dependency but no preload. Fall back to the installed rocm package in CMake too, so both read the same version. Test Plan: ``` cmake -P t.cmake # check_version='<installed rocm>' PYTORCH_ROCM_SDK_VERSION=9.9.9 cmake -P t.cmake # check_version='9.9.9' ``` Authored with an AI assistant (Claude Code). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rocm[libraries] leaves out rocm-sdk-device-gfx1201, which carries the GPU code objects for rocBLAS, MIOpen and the other kpack-split libraries; without it their kernels fail with hipErrorInvalidKernelFile. Authored with an AI assistant (Claude Code). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until reviewed.
Agent details (AI-generated)
🤖 Generated with Claude Code