Skip to content

Take the ROCm SDK version for _rocm_init.py from the build environment #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyyever merged 2 commits into from
Oct 23, 2026
Merged

Take the ROCm SDK version for _rocm_init.py from the build environment #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a86383c
Take the ROCm SDK version for _rocm_init.py from the build environment
cyyever Oct 23, 2026
c545515
Depend on the ROCm SDK device wheel too
cyyever Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/metadata/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ def dynamic_metadata(
if extra:
deps.extend(r.strip() for r in extra.split("|") if r.strip())
elif _is_truthy(os.environ.get("USE_ROCM")):
# Pin the ROCm SDK wheels the build used: PYTORCH_ROCM_SDK_VERSION when
# Pin the ROCm SDK wheels the build used, including the device wheel with
# the GPU code objects: PYTORCH_ROCM_SDK_VERSION when
# building against an unpacked SDK, else the installed rocm package.
rocm_version = os.environ.get("PYTORCH_ROCM_SDK_VERSION")
if not rocm_version:
Expand All @@ -71,7 +72,7 @@ def dynamic_metadata(
except PackageNotFoundError:
rocm_version = None
if rocm_version:
deps.append(f"rocm[libraries]=={rocm_version}")
deps.append(f"rocm[libraries,device]=={rocm_version}")

# cupti-python has no free-threaded wheels; PEP 508 cannot express this ABI constraint.
if sysconfig.get_config_var("Py_GIL_DISABLED"):
Expand Down
22 changes: 17 additions & 5 deletions torch/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,22 @@ endif()

# _rocm_init.py is gitignored (injected by ROCm build scripts to bootstrap
# torch/__init__.py). See https://github.com/ROCm/TheRock/blob/main/docs/packaging/python_packaging.md
# When building against the ROCm SDK wheels, PYTORCH_ROCM_SDK_VERSION names
# their version: generate the file so `import torch` preloads the SDK's
# libraries from those wheels and checks that the installed SDK matches.
if(USE_ROCM AND NOT "$ENV{PYTORCH_ROCM_SDK_VERSION}" STREQUAL "")
# Generate it for the ROCm SDK wheels this build targets, so `import torch`
# preloads their libraries and checks the installed SDK matches. The version is
# PYTORCH_ROCM_SDK_VERSION, else the rocm package in the build environment,
# matching tools/metadata/dependencies.py.
set(_rocm_sdk_version "$ENV{PYTORCH_ROCM_SDK_VERSION}")
if(USE_ROCM AND _rocm_sdk_version STREQUAL "")
execute_process(
COMMAND "${Python_EXECUTABLE}" -c "from importlib.metadata import version; print(version('rocm'), end='')"
OUTPUT_VARIABLE _rocm_sdk_version
RESULT_VARIABLE _rocm_sdk_result
ERROR_QUIET)
if(NOT _rocm_sdk_result EQUAL 0)
set(_rocm_sdk_version "")
endif()
endif()
if(USE_ROCM AND NOT _rocm_sdk_version STREQUAL "")
set(_rocm_preloads
amd_comgr amd_smi amdhip64 hiprtc hipblas hipfft hiprand hipsparse
hipsparselt hipsolver hipblaslt miopen rocm_sysdeps_liblzma rocm-openblas
Expand All @@ -482,7 +494,7 @@ if(USE_ROCM AND NOT "$ENV{PYTORCH_ROCM_SDK_VERSION}" STREQUAL "")
" import rocm_sdk\n"
" rocm_sdk.initialize_process(\n"
" preload_shortnames=[${_rocm_preloads}],\n"
" check_version='$ENV{PYTORCH_ROCM_SDK_VERSION}')\n")
" check_version='${_rocm_sdk_version}')\n")
endif()
# scikit-build-core won't include it via Python package collection. Install it
# explicitly via cmake instead.
Expand Down