Repository navigation
Add programDbId to BrAPIObservationVariable - #240
Open
jloux-brapi wants to merge 2 commits into
Open
jloux-brapi wants to merge 2 commits into
jloux-brapi wants to merge 2 commits into
Conversation
humsika
reviewed
Oct 28, 2026
| Objects.equals(this.synonyms, observationVariable.synonyms) && | ||
| Objects.equals(this.trait, observationVariable.trait); | ||
| Objects.equals(this.trait, observationVariable.trait) && | ||
| Objects.equals(this.programDbId, observationVariable.programDbId); |
There was a problem hiding this comment.
programName is in toString() but missing from equals() (here) and hashCode() (line 550). There’s also no fluent programName(String) builder like the one programDbId has. Can we add programName to equals and hashCode, and add the fluent setter for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2923
programDbIdto GET call in APIDependencies
Testing
Ontology PageShow Detailsand then clickingEdit, where if they are not already used you can edit some elements of the term. Activating and Deactivating also updates ontology. Simplify verify the changes are reflected once they are made.