Skip to content

Add programDbId to BrAPIObservationVariable #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jloux-brapi wants to merge 2 commits into
base: epic/BI-2862
Choose a base branch
from
Open

Add programDbId to BrAPIObservationVariable #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd46d47
Add programDbId to BrAPIObservationVariable
jloux-brapi Oct 27, 2026
3146914
Add programName to equals and hash, add builder method
jloux-brapi Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...a-client/src/main/java/org/brapi/client/v2/modules/phenotype/ObservationVariablesApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,8 @@ private Call variablesGetCall(VariableQueryParams queryParams) throws ApiExcepti
apiClient.prepQueryParameter(localVarQueryParams, "externalReferenceId", queryParams.externalReferenceId());
if (queryParams.externalReferenceSource() != null)
apiClient.prepQueryParameter(localVarQueryParams, "externalReferenceSource", queryParams.externalReferenceSource());
if (queryParams.programDbId() != null)
apiClient.prepQueryParameter(localVarQueryParams, "programDbId", queryParams.programDbId());
if (queryParams.page() != null)
apiClient.prepQueryParameter(localVarQueryParams, "page", queryParams.page());
if (queryParams.pageSize() != null)
Expand Down
44 changes: 40 additions & 4 deletions brapi-java-model/src/main/java/org/brapi/v2/model/pheno/BrAPIObservationVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ public class BrAPIObservationVariable {
@JsonProperty("trait")
private BrAPITrait trait = null;

@JsonProperty("programDbId")
private String programDbId = null;

@JsonProperty("programName")
private String programName = null;

private transient Gson gson = new Gson();

public BrAPIObservationVariable observationVariableName(String observationVariableName) {
Expand Down Expand Up @@ -129,8 +135,8 @@ public BrAPIObservationVariable observationVariablePUI(String observationVariabl
* Variable unique identifier MIAPPE V1.1 (DM-83) Variable ID - Code used to identify the variable in the data file. We recommend using a variable definition from the Crop Ontology where possible. Otherwise, the Crop Ontology naming convention is recommended: <trait abbreviation>_<method abbreviation>_<scale abbreviation>). A variable ID must be unique within a given investigation.
* @return observationVariablePUI
**/



public String getObservationVariablePUI() {
return observationVariablePUI;
Expand Down Expand Up @@ -485,6 +491,32 @@ public void setTrait(BrAPITrait trait) {
this.trait = trait;
}

public BrAPIObservationVariable programDbId(String programDbId) {
this.programDbId = programDbId;
return this;
}

public String getProgramDbId() {
return programDbId;
}

public void setProgramDbId(String programDbId) {
this.programDbId = programDbId;
}

public BrAPIObservationVariable programName(String programName) {
this.programName = programName;
return this;
}

public String getProgramName() {
return programName;
}

public void setProgramName(String programName) {
this.programName = programName;
}


@Override
public boolean equals(java.lang.Object o) {
Expand Down Expand Up @@ -514,12 +546,14 @@ public boolean equals(java.lang.Object o) {
Objects.equals(this.status, observationVariable.status) &&
Objects.equals(this.submissionTimestamp, observationVariable.submissionTimestamp) &&
Objects.equals(this.synonyms, observationVariable.synonyms) &&
Objects.equals(this.trait, observationVariable.trait);
Objects.equals(this.trait, observationVariable.trait) &&
Objects.equals(this.programDbId, observationVariable.programDbId) &&
Objects.equals(this.programName, observationVariable.programName);
}

@Override
public int hashCode() {
return Objects.hash(observationVariableDbId, observationVariablePUI, observationVariableName, additionalInfo, commonCropName, contextOfUse, defaultValue, documentationURL, externalReferences, growthStage, institution, language, method, ontologyReference, scale, scientist, status, submissionTimestamp, synonyms, trait);
return Objects.hash(observationVariableDbId, observationVariablePUI, observationVariableName, additionalInfo, commonCropName, contextOfUse, defaultValue, documentationURL, externalReferences, growthStage, institution, language, method, ontologyReference, scale, scientist, status, submissionTimestamp, synonyms, trait, programDbId, programName);
}

@Override
Expand All @@ -546,6 +580,8 @@ public String toString() {
sb.append(" submissionTimestamp: ").append(toIndentedString(submissionTimestamp)).append("\n");
sb.append(" synonyms: ").append(toIndentedString(synonyms)).append("\n");
sb.append(" trait: ").append(toIndentedString(trait)).append("\n");
sb.append(" programDbId: ").append(toIndentedString(programDbId)).append("\n");
sb.append(" programName: ").append(toIndentedString(programName)).append("\n");
sb.append("}");
return sb.toString();
}
Expand Down
Loading