Skip to content

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library - #516

Open
Tobias-Amaechina wants to merge 11 commits into
CodeYourFuture:mainfrom
Tobias-Amaechina:book-library
Open

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library#516
Tobias-Amaechina wants to merge 11 commits into
CodeYourFuture:mainfrom
Tobias-Amaechina:book-library

Conversation

@Tobias-Amaechina

@Tobias-Amaechina Tobias-Amaechina commented Aug 5, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Corrected validation logic to ensure title, author, and pages fields are required before adding a book.

Fixed bug where the author field was ignored and replaced with the title value.

Corrected array reference (library → myLibrary) to prevent runtime errors when adding books.

Repaired table‑rendering loop by fixing a missing parenthesis in the row‑deletion logic.

Corrected read/unread status logic so check === true displays “Yes”.

Fixed delete‑button creation:

Corrected variable name (delButton instead of delBut)

Removed accidental reassignment of the button element

Corrected event listener from "clicks" to "click"

Ensured delete action removes the correct book and re-renders the table

@Tobias-Amaechina Tobias-Amaechina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 5, 2026
@Tobias-Amaechina Tobias-Amaechina added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 5, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Tobias-Amaechina Tobias-Amaechina changed the title Birmingham | 26-ITP-May | Tobias Amaechina Sprint 2 | Book-library Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library Aug 5, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Tobias-Amaechina Tobias-Amaechina added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected and removed 🏕 Priority Mandatory This work is expected labels Aug 5, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants