Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library - #516
Open
Tobias-Amaechina wants to merge 11 commits into
Open
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library#516Tobias-Amaechina wants to merge 11 commits into
Tobias-Amaechina wants to merge 11 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Tobias-Amaechina
force-pushed
the
book-library
branch
from
August 5, 2026 22:30
abaaa14 to
2606f98
Compare
cjyuan
reviewed
Aug 6, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Corrected validation logic to ensure title, author, and pages fields are required before adding a book.
Fixed bug where the author field was ignored and replaced with the title value.
Corrected array reference (library → myLibrary) to prevent runtime errors when adding books.
Repaired table‑rendering loop by fixing a missing parenthesis in the row‑deletion logic.
Corrected read/unread status logic so check === true displays “Yes”.
Fixed delete‑button creation:
Corrected variable name (delButton instead of delBut)
Removed accidental reassignment of the button element
Corrected event listener from "clicks" to "click"
Ensured delete action removes the correct book and re-renders the table