Skip to content

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tobias-Amaechina wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Book-library #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
686f27d
added the closing parenthesis in the for loop
Tobias-Amaechina Aug 5, 2026
11d4e80
used the correct variable name myLibrary inside the submit function
Tobias-Amaechina Aug 5, 2026
9acc884
added the autho.value by deleting one of the title.value that was pa…
Tobias-Amaechina Aug 5, 2026
127e4f4
changed every instance of delBut with delButton
Tobias-Amaechina Aug 5, 2026
8314db5
correct the event name by it correct name click
Tobias-Amaechina Aug 5, 2026
8c9db43
changed the wrong logically check from false to yes
Tobias-Amaechina Aug 5, 2026
f839c7b
added additional validation for book's author
Tobias-Amaechina Aug 5, 2026
ab117d6
remove the table element from the index.html
Tobias-Amaechina Aug 5, 2026
55bfed4
add the button ID
Tobias-Amaechina Aug 5, 2026
ab20798
appen the corrent variable name delButton
Tobias-Amaechina Aug 5, 2026
2606f98
let the row start to add from top
Tobias-Amaechina Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,7 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>

</table>

<script src="script.js"></script>
Expand Down
23 changes: 13 additions & 10 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,17 @@ function submit() {
if (
title.value == null ||
title.value == "" ||
author.value == null ||
author.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);

render();
}
}
Expand All @@ -54,13 +57,13 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n-- ){
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let row = table.insertRow(-1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
Expand All @@ -76,7 +79,7 @@ function render() {
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
if (myLibrary[i].check == true) {
readStatus = "Yes";
} else {
readStatus = "No";
Expand All @@ -90,11 +93,11 @@ function render() {

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delButton.id = i + 5;
deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";
delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down
Loading