Skip to content

fix: always split the gene cell of uniprot.tsv into its gene names - #36

Merged
edkerk merged 2 commits into
developfrom
fix/uniprot-gene-split
Nov 19, 2026
Merged

edkerk merged 2 commits into
developfrom
fix/uniprot-gene-split

Conversation

@edkerk

@edkerk edkerk commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

loadDatabases splits a gene cell of uniprot.tsv that holds several gene names, such as YPR080W; YBR118W, into one row per name. The split is on semicolons and white space, the other columns repeat on every row, and an empty cell stays one row. A model gene that is any of the names now finds its UniProt entry in makeEcModel and getECfromDatabase. The splitGeneCells option of loadDatabases and getECfromDatabase is removed. The geckopy counterpart is CompMetEng/geckopy#95.

A gene cell such as 'YPR080W; YBR118W' is expanded into one database row per
gene name, split on semicolons and whitespace. The splitGeneCells option of
loadDatabases and getECfromDatabase is removed.
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Unit test results

104 tests   104 ✅  16s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 5313c90.

♻️ This comment has been updated with latest results.

@edkerk
edkerk merged commit 0cd8005 into develop Nov 19, 2026
3 checks passed
@edkerk
edkerk deleted the fix/uniprot-gene-split branch November 19, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant