Repository navigation
fix: always split the gene cell of uniprot.tsv into its gene names - #36
Merged
Merged
Conversation
A gene cell such as 'YPR080W; YBR118W' is expanded into one database row per gene name, split on semicolons and whitespace. The splitGeneCells option of loadDatabases and getECfromDatabase is removed.
Unit test results104 tests 104 ✅ 16s ⏱️ Results for commit 5313c90. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadDatabasessplits a gene cell ofuniprot.tsvthat holds several gene names, such asYPR080W; YBR118W, into one row per name. The split is on semicolons and white space, the other columns repeat on every row, and an empty cell stays one row. A model gene that is any of the names now finds its UniProt entry inmakeEcModelandgetECfromDatabase. ThesplitGeneCellsoption ofloadDatabasesandgetECfromDatabaseis removed. The geckopy counterpart is CompMetEng/geckopy#95.