Skip to content

fix: always split the gene cell of uniprot.tsv into its gene names - #95

Merged
edkerk merged 4 commits into
developfrom
fix/uniprot-gene-split
Nov 19, 2026
Merged

edkerk merged 4 commits into
developfrom
fix/uniprot-gene-split

Conversation

@edkerk

@edkerk edkerk commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

load_uniprot_tsv splits a gene cell that holds several gene names, such as YPR080W; YBR118W, into one row per name, on semicolons and white space, so a model gene that is any of the names finds its UniProt entry in make_ec_model and fill_eccodes_from_database. The split_gene_cells argument is removed. The docstring of fill_kcats_from_isozymes names the renamed MATLAB function fillKcatsFromIsozymes. The GECKO counterpart is CompMetEng/GECKO#36.

A gene cell such as 'YPR080W; YBR118W' is expanded into one row per gene
name, split on semicolons and whitespace. The split_gene_cells option of
load_uniprot_tsv is removed.
@edkerk
edkerk merged commit 117d179 into develop Nov 19, 2026
8 checks passed
@edkerk
edkerk deleted the fix/uniprot-gene-split branch November 19, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant