Repository navigation
[18.0] FIX sponsorship_compassion: ZeroDivisionError in origin conversion rate - #2212
Merged
Merged
Conversation
…as sub sponsorships Assigning a SUB sponsorship to an origin whose contracts all have a parent raised ZeroDivisionError in _compute_won_sponsorships. Compute the stats for every origin (reset when no contract left), default the rate to 0 and also depend on contract parent_id/state. Assisted-by: claude-opus-5-5, medium, claude-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Assigning a SUB sponsorship (via
sds.subsponsorship.wizard) crashed with:The conversion rate only counts contracts without a
parent_id. When the origin of the SUB only has sub sponsorships, the denominator is 0.Fix
conversion_ratefalls back to0.0when the origin has no contract without a parent.@api.dependsalso coverscontract_ids.parent_idandcontract_ids.state, which the compute already reads.Notes
-u sponsorship_compassionalso recomputes the stored values that are already wrong.🤖 Generated with Claude Code