Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions sponsorship_compassion/models/contract_origin.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,14 @@ def _get_origin_types(self):
("other", _("Other")),
]

@api.depends("contract_ids.origin_id", "contract_ids.activation_date")
@api.depends(
"contract_ids.origin_id",
"contract_ids.activation_date",
"contract_ids.parent_id",
"contract_ids.state",
)
def _compute_won_sponsorships(self):
for origin in self.filtered("contract_ids"):
for origin in self:
# not tacking sponsors with parent_id or in cancelled state.
contract_ids = origin.contract_ids.filtered(lambda c: not c.parent_id)
origin.won_sponsorships = len(
Expand All @@ -107,9 +112,9 @@ def _compute_won_sponsorships(self):
# sponsor who cancelled their sponsorship are used to compute
# conversion_rate to avoid bias
origin.conversion_rate = (
len(contract_ids.filtered("activation_date"))
/ float(len(contract_ids))
* 100
len(contract_ids.filtered("activation_date")) / len(contract_ids) * 100
if contract_ids
else 0.0
)

##########################################################################
Expand Down
Loading