Skip to content

T3423 desktop new sponsorship view - #387

Draft
danpa32 wants to merge 43 commits into
18.0from
T3423-desktop-new-sponsorship-view
Draft

danpa32 wants to merge 43 commits into
18.0from
T3423-desktop-new-sponsorship-view

Conversation

@danpa32

@danpa32 danpa32 commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Note: this PR must be tested on stage before it is put on production.

T3423 — Desktop layout for the new-sponsorship flow

Original ask

Redesign the new-sponsorship wizard flow's desktop layout. The flow was built mobile-first (single column); desktop needs a two-column layout (form/summary on one side, a highlighted status/child-summary panel on the other) across every page in the flow: the fast-checkout step (standard flow), the Write&Pray fast-checkout step, the thank-you page (all its branches, including the public "All set" summary), and the post-payment contact-details form. Mobile layout is unchanged throughout.

Related PR

CompassionCH/compassion-switzerland#1818

What changed

Two repos

compassion-website (my_compassion module)

Established pattern, reused on every page: .ns-flex-columns (desktop-only two-column flex row, @media (min-width: 992px)), .ns-highlight-panel / .ns-aside-item for the two columns, .ns-split-blue-left / -right (a full-viewport-width ::before gradient behind the row, independent of which physical column holds which content).

  • 73366c5, ed7abd0, 7c33005, bb14441, 37ee41d — initial desktop layout and left-column headings for the fast-checkout step, then split my2_new_sponsorship_wizard.xml into per-step partial files.
  • 1d673c2, d50f368 — full two-column layout, payment-mode radios, live total, full-width split background for the standard fast-checkout step.
  • eba393b, 127023d — same two-column pattern applied to the thank-you page; folder reorganized (my2_new_sponsorship_wizard/ → my2_new_sponsorship/) to hold the whole flow's non-wizard-step pages too (payment redirect, post-payment details form, thank-you page).
  • fc05e16, ab6f16e, e356a73, 1c890dc — the "All set" public-signup summary branch extracted out of the thank-you page into its own template (all_set.xml), then iterated on extensively per design feedback: title + description merged into one component call, two-column layout, mobile ordering (summary before the volunteering card + dashboard button, at the very end of the page), unequal column heights accepted instead of forcing a shared height, Sponsorship+ modal close-button float fix.
  • 112c48b — same two-column layout for the Write&Pray fast-checkout step (previously had a couple of the right CSS classes sprinkled on with no actual two-column wrapper); date of birth + email side by side on desktop; a desktop-only Continue button in the left column instead of the shared chrome's button below the columns; a "How Write&Pray works" info box.
  • e3d3403 — "Godparent" → "Sponsorship" wording for the free W&P role label (design/copy consistency, not structural).
  • ce5d81b — the generic Odoo core error page (http_routing.400, shown for UserErrors like "child no longer available") restyled to match the site's branding — only the production branch, debug/traceback view for developers is untouched.
  • bbe41c6, 9b52d39 — two real translatability bugs found and fixed: the thank-you page's letter-card text ("<Child> is expecting your letter", "He/She writes back by name...") and the All Set page's "Received"/"Pending" payment status were built via Python string concatenation/ternaries inside t-value/t-out expressions, which Odoo's --i18n-export never parses into — these strings were never present in any .po file, in any language, regardless of how long the module had shipped. Restructured into the standard block-form t-set/t-if pattern.
  • 0827b16, a025f92, 89336a2 — translated all of the above (plus everything else new on these pages) into German, Swiss French, Italian, Finnish and Swedish. See "Translations" below.

compassion-switzerland

  • 8e609ce9 — the "All set" extraction (above) broke two CH-only inherited views that anchored on content that moved into the new template (new_sponsorship_wizard_volunteering's xpath on wap-preferences-card, and my2_new_sponsorship_thank_you_pending_payment's xpath on a mx-4 div — the latter's anchor turned out to have never matched the page's real top-level title at all, since that title sets its class via t-attf-class, invisible to a static-XML hasclass() xpath; it was actually matching the All-Set branch's own title div all along). Re-pointed both inherit_ids to the new template.
  • a4dc6a67, 1a03e339 — follow-up polish on the CH-specific pieces of the same page: pending-payment notice relocated to the bottom of the summary column and restyled, "Want to do more?" alignment.
  • 31234ab6 — real bug, unrelated to the redesign but found while testing it: the /legal redirect (used by every privacy-policy link across the site, not just this flow) was landing on a broken local path. request.redirect() defaults to local=True, which unconditionally strips the scheme/host from any URL passed to it — so the absolute https://compassion.ch/... targets were silently turned into same-site relative redirects. Fixed with local=False; also fixed a stray double-slash in the Italian URL.
  • cf2c962d — translated the volunteering opt-in card + its info modal (de, fr_CH, it) — see "Translations" below.

Translations

Full T3423 scope (All Set page, Write&Pray step, thank-you page letter card, custom_400 error page, volunteering opt-in card + modal) translated into German, Swiss French, Italian (my_compassion + my_compassion_switzerland) and Finnish, Swedish (my_compassion only — Nordic doesn't install my_compassion_switzerland).

How to test manually

  1. -u my_compassion (and -u my_compassion_switzerland for the CH-specific pieces) on a dev server, --dev=all.
  2. Standard flow desktop: `/my2/sponsorships and select a child to sponsor. Follow the steps and add information in the fields throughout the standard flow
  3. Write&Pray flow desktop: same route but on the url path, change standard to write_and_pray after selecting a child — two-column fast-checkout step (date of birth + email side by side, desktop Continue button, "How Write&Pray works" box), then its own "All set" variant.
  4. Mobile (< 992px): confirm nothing above regressed — single column, All Set page order is title → summary → volunteering card → dashboard button.
  5. /legal: Check the Privacy policy in the new-sponsorships page. Hit it directly in French/German/Italian browser locale (or /de/legal, /it/legal) and confirm it 301s to the real compassion.ch page, not a local path.
  6. Error page: trigger a UserError on a /my2/... route in a non-debug session and confirm the branded design shows instead of Odoo's plain "Oops!" page;
  7. Translations: switch site language to German/French/Italian (both repos) or Finnish/Swedish (Nordic compassion-website checkout only)
Screencast.From.2026-09-09.14-40-27.mp4
Screencast.From.2026-09-09.14-42-37.mp4
Screencast.From.2026-09-10.09-59-17.mp4

Review round (T3423): fixes on top of the redesign

The branch was reviewed and tested end to end on a copy of the Nordic database: Stripe test payments, desktop and mobile, in sv / fi / nb / da / en. The following commits were added on top:

  • Merge 18.0. This brings in the [IMP] my_compassion, theme_compassion_2025: terms and conditions apart from the privacy policy #443 terms-and-conditions consent label and the [T3465] my_compassion: hooks for a required post-payment details form #438 details-form hooks (my2_new_sponsorship_details_extra_fields, the _my2_details_mandatory() guard).
  • Details form heading is a div.h4 again. my_compassion_nordic inherits the form and anchors on that heading. With an <h4>, -u my_compassion failed on Nordic.
  • my_compassion_payment_payu_gpo. The payment-mode buttons became radios, so the PayU xpath on my2_new_sponsorship_wizard_form_content found nothing and the upgrade failed. data-payu-gpo now goes on the radios, and the cardholder-name check reads it from the Continue button, like the payment mode.
  • Payment mode.
    • Continue with no mode selected now shows an inline message instead of ending on the 400 page.
    • The checked radio's data is copied to the button as jQuery data too. jQuery caches .data(), so the eBill handler could act on the mode of an earlier click. The list of copied keys is paymentModeDataKeys, and modules can extend it.
  • Live total.
    • It follows any input named sponsorship_plus, so a country module can replace the checkbox with radios that use the value 0 for "without Plus".
    • The JS rewrites only the amount, so the translated /mo. suffix stays.
  • Logged-in Write&Pray keeps the shared Continue button on desktop. Only the public step has its own.
  • Branded 400/404 pages only on theme_compassion_2025 websites. They call the theme's components, so on the other websites (crowdfunding, Muskathlon, the default website) rendering failed and Odoo fell back to a bare 418 page.
  • Thank-you title in one place: my2_new_sponsorship_thank_you_title, called from both of its spots, so a country module rewords it once.
  • Split background now shows on boxed layouts. The ::before is a positioned layer at z-index 0, and the row's children are positioned above it. No stacking context is created, so the Sponsorship Plus modal still opens above the header.
  • One desktop breakpoint, 992px (Bootstrap lg, like the templates' d-lg-* classes). The container widened only at 1024px, so from 992 to 1023px both columns were squeezed into 500px.
  • theme_compassion_2025 field validation. A shown error now clears as soon as the field is valid. Before, it cleared on blur, which happens on the mousedown of the next click: the page moved up under the pointer and the click was lost. On the fast checkout, that could leave an earlier payment mode checked and submit it.
  • Translation files rebuilt from a fresh export, so moved terms point to their new templates.
    • The UPD translations fr_CH, de_DE, it_IT #418 de/fr_CH/it translations that the 18.0 merge had emptied are back.
    • Norwegian added for the pages a Norwegian visitor sees. These Norwegian texts are AI-written and need a native check.
  • Test test_page_holds_the_email_the_consent_and_a_radio_per_mode updated for the radios. With these commits, my_compassion's suite fails exactly the tests that already fail on plain 18.0 (same database). my_compassion_payment_payu_gpo installs, and its 42 tests pass.

Deployment

  • Switzerland: together with T3423 desktop new sponsorship view compassion-switzerland#1818, which re-points the thank-you xpaths. -u my_compassion also upgrades my_compassion_payment_payu_gpo and my_compassion_switzerland.
  • Nordic: -u my_compassion. The current my_compassion_nordic works unchanged with this branch.

danpa32 and others added 21 commits September 2, 2026 11:02
Adds a two-column desktop breakpoint (>=1024px, CSS Grid) for the
standard and Write&Pray fast-checkout steps, and the thank-you/details
and all-set pages, reusing the existing child-summary card as the
sidebar. Mobile layout is unchanged below the breakpoint.
Matches the Figma desktop layout: the standard and Write&Pray
fast-checkout steps get their own left-column title/description
(hidden on mobile), and the shared wizard-chrome title is hidden on
desktop for these two steps specifically (wizard.details_deferred) to
avoid double-titling. Other steps (payment-methods, wap_options, etc.)
keep the generic chrome title on desktop unchanged.
TitleComponent centers by default (theme_compassion_2025's
title-component base rule), fine for the shared wizard-chrome title
but not for the new left-column headings sitting beside the sidebar.
The file had grown to 1382 lines across 11 templates spanning several
unrelated flows (standard checkout, Write&Pray, the older logged-in
steps, the thank-you page), making it hard to navigate. Split into
templates/pages/my2_new_sponsorship_wizard/, one file per logical
group, no behavioral change: t-call resolves by module+id at render
time regardless of which file defines a template, and the same 32
fast-checkout tests pass/fail identically before and after (2
pre-existing, unrelated failures).
The previous split commit removed the monolithic
my2_new_sponsorship_wizard.xml but never updated the manifest's data
list, so none of the 7 split templates have actually been loading
since that commit.
…t-checkout step

Adds a flexbox-based two-column desktop layout to standard_step.xml
(donation summary + Sponsorship Plus on one side, contact info +
payment mode on the other), alongside the pre-existing CSS-grid
.ns-columns pattern used by the thank-you page.

Converts the fast-checkout page's payment-mode buttons to radios,
moved into the step's own left column instead of the parent chrome's
button-per-mode row (deleted, now dead code). The eBill extension's
click-time data-payment-code detection is kept working via a JS
handler that syncs the checked radio onto the shared Continue button,
which itself also moved into the left column so the desktop layout's
highlighted column can stretch down to the footer.
…r the fast-checkout step

- Full-viewport-width blue/white split background (a breakout pseudo-
  element) behind the two-column layout, instead of a color scoped to
  one column's own box.
- Live "Total" amount in the right column, kept in sync with the
  Sponsorship Plus toggle client-side (no step round-trip).
- Payment-mode radios: bigger circles, custom checked/hover styling,
  corner rounding only on the first/last row.
- Continue button goes full-width on mobile.
- Sponsorship Plus's checkmark is now a real icon instead of a raw ✓
  character, which wasn't rendering consistently.
- Copy and color tweaks: step heading/description, E-mail label,
  "Already have an account" banner hidden on desktop.
…he thank-you page

Reuses the .ns-flex-columns/.ns-highlight-panel/.ns-split-blue-*
pattern built for the fast-checkout step, this time with the blue
column on the left (new .ns-split-blue-left variant) - donation
summary/status details on the blue side, the "who shall we thank"
form and the "all set" actions on the white side.

Also reworks the "who shall we thank" post-payment details form:
firstname/surname side by side on desktop, address disclosure and
button spacing, left-aligned heading on desktop, and the letter card
(name/subtext/photo, price hidden, white background) that replaces
the country/price framing for that specific card only.
…ove payment/details pages into it

The folder held every wizard step template already; moving in
my2_new_sponsorship_payment.xml (provider-payment checkout) and
my2_new_sponsorship_details.xml (post-payment "Who shall we thank?"
form) groups the whole /my2/new-sponsorship/ journey together instead
of splitting it across two locations. Dropping "_wizard" from the
folder name reflects that it's no longer wizard-steps-only.
Move the thank-you page's "All set" branch (public-signup summary:
status box, child/WAP card, dashboard link) out of thank_you_page.xml
into a new all_set.xml, called via t-call from the parent template's
t-elif chain. It was the largest, most self-contained of that
template's four branches.
Merge the standalone sign-in-link paragraph into the title's own
description slot (theme_compassion_2025.TitleComponent), mid-grey.
Rework the two-column split: left column keeps the title/description,
the volunteering opt-in card and the dashboard button; right column
now holds only the sponsorship summary box, with the light-blue split
background moved to that side to match. Remove the child card. Add
mid-grey dividers with more breathing room between summary rows (none
after the last one), and use a smaller border radius on the dashboard
button. Hide the page's own top-level "Thank you for sponsoring..."
title for this branch specifically, since it now has its own.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…t" page

Reorder the DOM so the summary column comes before the title/
volunteering-card/dashboard-button column - mobile's plain block
stacking then reads summary, then the volunteering section and
button, at the very end of the page, with no extra CSS needed. On
desktop, use plain flex `order` (not CSS Grid) to put the columns
back in their usual visual positions: this avoids Grid's row-span
height coupling, which was stretching the title/volunteering column
to match the summary box's height and inserting a visible gap between
the title's description and the volunteering card - unequal column
heights are accepted instead. Also scope the thank-you page's added
bottom margin to mobile only.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…class

Same fix as the volunteering info modal: the close button was sitting
in normal document flow above the title instead of floating in the
corner, pushing the title down. Also fix "Your contact information"'s
heading margin - "smt-5" isn't a real utility class, so the intended
top margin was silently a no-op; corrected to "mt-5".

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…eckout step

Add the ns-flex-columns/ns-split-blue-right wrapper (matching
standard_step.xml's reversed layout) and move the child summary card
and the desktop title/form fields into their respective columns -
previously only a couple of the desktop-specific classes were sprinkled
on with no actual two-column wrapper. Also: date of birth and email
side by side on desktop; a desktop-only Continue button in the left
column instead of relying on the shared chrome's button below the
columns (same reasoning as standard_step.xml's own button), which now
hides itself with d-lg-none specifically for this flow on mobile still
using the shared one; a "How Write&Pray works" info box below the
child card, desktop only.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…nslatable

"<Child> is expecting your letter" and the gender-aware "He/She writes
back by name..." subtext were built via Python string concatenation
inside t-value expressions, which Odoo's translation extraction never
sees - these strings were never even present in the .po files to
translate, in any language. Restructured into the standard block-form
t-set pattern (literal text + a nested t-out for the child's name, a
t-if/t-else pair instead of a ternary) already used elsewhere on this
page, which is what actually gets picked up by --i18n-export.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
http_routing.400 (Odoo's core error page, shown for UserError-type
exceptions like "child no longer available") gets the same branded
treatment as the existing custom_404 override - only the production
(non-debug) branch is touched, the debug/traceback accordion is left
alone since that's what's actually needed while developing. Also fixes
a dead parameter: http_error_custom already received an error_message
value (used by the 404 override) but never displayed it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…e label

Consistency tweak in the "All set" summary row and its matching
docstring comment. Also drop a stray nbsp between the currency name and
the amount in the standard-flow monthly-gift row.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Covers the "All set" page redesign, the Write&Pray fast-checkout
step's new content, and the thank-you page's now-translatable letter
card text - none of it existed in these three locales' .po files
before. Also carries the Godparent -> Sponsorship rename's msgid
across fi_FI/nb_NO/sv_SE, keeping their existing translations attached
instead of losing them to a stale-entry drop.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Same bug as the letter-card text: built via a Python ternary inside
t-out="...", which Odoo's translation extraction never sees. Restructured
into a t-if/t-else pair.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…_SE)

Same T3423 scope already translated for de/fr_CH/it: the "All set" page
redesign, the Write&Pray fast-checkout step's new content, the
custom_400 error page, and the thank-you page's now-translatable
letter card text - plus "Pending" on the All Set page's payment status.
Followed glossary-nordic.md (informal du/sinä register, fadder/kummi
for sponsor terminology).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…, it

"Received" was already translated (reused from my2_child_letters_page);
only "Pending" was genuinely missing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…path

oca-checks-odoo-module flags position="replace" on a view without a high
enough priority (xml-dangerous-qweb-replace-low-priority) - a low-priority
replace risks silently clashing with other modules extending the same
node. custom_404 doesn't need this since it only uses attributes/after.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ecino
ecino marked this pull request as draft October 29, 2026 06:19
Assisted-by: claude-sonnet-5-5, medium, claude-code
@ecino
ecino force-pushed the T3423-desktop-new-sponsorship-view branch from cf3a1f9 to ec2111b Compare October 29, 2026 06:34
Conflicts resolved:
- my2_new_sponsorship_wizard.xml (split by this branch): the terms and
  conditions consent label from #443 goes into standard_step.xml and
  wap_step.xml.
- my2_new_sponsorship_details.xml: this branch's layout, with #438's
  my2_new_sponsorship_details_extra_fields hook after the name row and its
  _my2_details_mandatory() guard on the "Do this later" button.
- de_DE, fr_CH, it_IT .po: 18.0's side of the single conflicting hunk.

Assisted-by: claude-opus-5-5, xhigh, claude-code
Country modules inherit my2_new_sponsorship_details_form and anchor on its
div.h4 heading and the intro line after it; an <h4> made the Nordic view's
xpath fail and stopped the module upgrade.

Assisted-by: claude-opus-5-5, xhigh, claude-code
- The payment-mode radios have no default: Continue now stops with an inline
  message while none is checked, instead of submitting and ending on the
  400 page.
- The checked radio's data-* keys are copied onto the Continue button as
  jQuery data too (a .data() read is cached, so the eBill click handler
  kept the mode of an earlier click), from a key list modules can extend.
- The live total follows any input named sponsorship_plus (the checkbox, or
  radios with value 0 for without Plus) and rewrites only the amount, so
  the translated /mo. suffix stays.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…ntinue

Only the public Write&Pray step renders its own desktop Continue button; the
logged-in step (wap_options) relies on the shared one, which was hidden on
desktop for every Write&Pray step.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…ion_2025 websites

http_error_custom calls theme_compassion_2025 components, which exist only
on the websites using that theme. Elsewhere (crowdfunding, Muskathlon, the
default website) rendering the 400 or 404 failed and Odoo fell back to its
bare 418 page. Those websites keep the core page now; the 400 also keeps it
in debug and edit mode, and the branded block no longer nests a second
div#wrap.

Assisted-by: claude-opus-5-5, xhigh, claude-code
The thank-you page renders its title twice (top-level, and the desktop left
column while the details form shows). Both now call
my2_new_sponsorship_thank_you_title, so a country module rewords it once.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…ackgrounds

The full-width ::before sat at z-index -1 and a boxed layout's <main> painted
its white background over it, leaving only a strip outside the box. It is
now a positioned layer at z-index 0 with the row's children positioned
above it in tree order; no stacking context is created, so the Sponsorship
Plus modal inside the row still stacks above the site header.

Assisted-by: claude-opus-5-5, xhigh, claude-code
Assisted-by: claude-opus-5-5, xhigh, claude-code
…ast checkout radios

The fast checkout's payment-mode buttons became radios in
my_compassion's fast-checkout step, so the xpath on
my2_new_sponsorship_wizard_form_content found nothing and the module
upgrade failed. data-payu-gpo now goes on the radios, and the Continue
button mirrors it (paymentModeDataKeys) for the cardholder-name check.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…'s terms

Every language file is rebuilt from a fresh export of my_compassion, so
each term carries the references of the templates it now lives in (the
split moved terms to new templates, and view translations are imported per
template), and terms no longer in the module are gone. Translations come
from this branch, else from 18.0: the de_DE, fr_CH and it_IT translations
of #418 that the 18.0 merge had emptied are back.

New: Norwegian for the pages a Norwegian visitor sees in the new layout
(fast checkout, thank-you, details form, All set), and the 400 page title
in de_DE, fr_CH and it_IT. The payment-mode message shown under the radios
reuses the server message, already translated.

Assisted-by: claude-opus-5-5, xhigh, claude-code
The page offers a radio per published payment mode and one Continue button
(id finish_button), with the message shown while no mode is checked.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…w-sponsorship pages

The two columns started at 992px while the container stayed capped at 500px
until 1024px: from 992 to 1023px both columns were squeezed into it. The
container, the grid and the left-column titles now switch at 992px too, like
the templates' d-lg-* classes.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…it is valid

The error hint of a field only went away on blur, which happens on the
mousedown of the visitor's next click: the page moved up under the pointer
and that click was lost. On the fast checkout it could land on the radio
above the one clicked, or leave an earlier payment mode checked. While an
error is shown, editing the field (or ticking the checkbox) now clears it as
soon as the value is valid; a new error is still only shown on blur.

Assisted-by: claude-opus-5-5, xhigh, claude-code
@NoeBerdoz
NoeBerdoz marked this pull request as ready for review November 9, 2026 16:16
… validated input

The widget validates the first input of its .form-field-component. Typing
in another input of the same wrapper cleared that input's error too: a
custom donation amount sits behind its hidden radio, so typing -12 after a
failed submit removed the amount's error while it was still invalid. Only
input events from the validated input clear an error now.

Assisted-by: claude-opus-5-5, xhigh, claude-code
… two columns

The 1100px desktop width applied to every wizard step and every thank-you
branch. The logged-in payment step and the logged-in thank-you page, which
stay single-column, were stretched across the page. Only a container that
holds a two-column row is widened now; the others keep their 500px and
768px.

Assisted-by: claude-opus-5-5, xhigh, claude-code
… and Continue

Comments and docstrings still described one submit button per payment mode;
the step offers radios and its own Continue submits the checked one. Also
drops a history note from all_set.xml and a wrong escaping rationale from
the thank-you title.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…-card wording

Three fr_CH Write&Pray texts said tu on a step whose other texts say vous
(18.0 had vous for the role line). The nb_NO letter-card line read
"skriver tilbake til deg ved navn", which is not how Norwegian says it.

Assisted-by: claude-opus-5-5, xhigh, claude-code
The texts this PR adds or rewords had no Danish, so a Danish visitor saw
the fast checkout, the thank-you letter card, the details form and the
"All set" summary partly in English. Filled for every page a Danish
visitor sees; the Switzerland-only Write&Pray step is left out. Written
by an AI with the module's existing Danish terms (fadderskab, fadderbarn,
Fadder Plus, betalingsmetode): they need a native check, like the
Norwegian ones.

Assisted-by: claude-opus-5-5, xhigh, claude-code
The Write&Pray step speaks to its under-25 audience with tu, the deliberate
exception to vous in the Swiss French texts. Three of its texts had been
turned to vous; they say tu again.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…eading

The details form's heading reads "Your contact information"; three tests
still looked for "Who shall we thank?" and failed on a database where the
rest of their checks pass.

Assisted-by: claude-opus-5-5, xhigh, claude-code
@NoeBerdoz

Copy link
Copy Markdown
Contributor

Review round 4 (T3423)

An independent review of 7d8e3c5 in three parts: a code review, a browser E2E on a copy of the Nordic database (Stripe test payments; desktop, mobile and logged-in; sv, fi, nb, da, en), and a check of every translation of the new-sponsorship pages. Fixes pushed in 7d8e3c5..c455814.

Fixed in this PR

  • The logged-in payment step and the logged-in thank-you page were stretched to 1100px on desktop. Only pages with the two-column layout are widened now; the others keep their 500px and 768px.
  • theme_compassion_2025 validator: typing a still-invalid custom donation amount cleared its error. Only input from the field the widget validates clears an error now.
  • Comments still described one submit button per payment mode; they describe the radios and the Continue button.
  • Danish: the texts this PR adds had no Danish. Added for every page a Danish visitor sees. AI-written, needs a native check, like the Norwegian ones.
  • Norwegian: the letter-card line ("writes back by name") is reworded.
  • Three tests still looked for the details form's old heading "Who shall we thank?".

Checked, no change

  • Paired name fields at 992–1023px: no overflow (measured in the browser).
  • The mobile "All set" child card: removed on purpose in ab6f16e.
  • Swiss French Write&Pray texts keep tu, the brand's choice for the under-25 audience.

Switzerland

The two PRs must deploy together. This PR alone fails the Swiss upgrade: two my_compassion_switzerland views anchor on markup that moved into the new "All set" template. CompassionCH/compassion-switzerland#1818 alone fails too, because its views target that template.

Checked on a copy of the Swiss database upgraded to today's 18.0 (-u all), with this PR and #1818 (merged locally with today's 18.0):

  • -u my_compassion,my_compassion_switzerland succeeds.
  • The my_compassion and my_compassion_switzerland tests fail exactly the same 29 tests as plain 18.0 on that database (308 tests). Nothing new fails.
  • Fixed in #1818 (38605a09): the eBill setup box, appended at the end of the fast-checkout step, landed below both columns, after Continue. It sits above the payment-mode radios again, as its test expects.
  • #1818 is still a draft and conflicts with 18.0: three .po files, and website_switzerland/controllers/website_sale.py, where 18.0 already moved and fixed /legal, so its change there is no longer needed.
  • A Swiss browser E2E round comes next.

Translations older than this PR

The translation check also found errors that are already on 18.0 (e.g. the postal-code field labelled "Kinder Ref." / "Réf. Enfant", a German payment sentence that stops mid-clause, the child's name printed twice in German). They are fixed separately in #451, stacked on this PR.

E2E results (Nordic copy)

Public desktop and mobile checkouts and a logged-in checkout completed with Stripe test payments. Two columns from 992px, the Sponsorship Plus modal above the header, field hints clearing while typing, error pages returning 400/404 (never 418), no JS errors. Images and icons are missing locally (no filestore), which is expected.

@NoeBerdoz
NoeBerdoz marked this pull request as draft November 11, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants