Skip to content

[T3423] my_compassion: translation errors found in review - #451

Draft
NoeBerdoz wants to merge 2 commits into
T3423-desktop-new-sponsorship-viewfrom
T3423-i18n-followup
Draft

NoeBerdoz wants to merge 2 commits into
T3423-desktop-new-sponsorship-viewfrom
T3423-i18n-followup

Conversation

@NoeBerdoz

Copy link
Copy Markdown
Contributor

T3423 — Translation errors found in review (my_compassion)

Stacked on #387. Base is T3423-desktop-new-sponsorship-view
for now, so the diff shows only these fixes. Retarget to 18.0 once #387 is merged.
It is stacked because #387 rebuilt every .po file; a branch from 18.0 would conflict.

Why

The review of #387 checked the translations of the new-sponsorship pages in every language.
Most problems it found are older than #387 (the same text is on 18.0). This PR fixes only the
ones that are plainly wrong for the reader. Wording and style preferences are left alone.

What changed

Only msgstr values in my_compassion/i18n/*.po. No code, no template, no manifest change.

German (de_DE)

  • "Code" on the details and user-details forms is the postal code field. It read "Kinder Ref."
    (a child reference). Now "PLZ".
  • Payment page: "Bezahle den ersten Monat, um deine Patenschaft für ." stopped mid-clause.
    Now "Bezahle den ersten Monat und starte deine Patenschaft für ."
  • "All set" first-letter prompt: "Ein Brief bedeutet ihm unglaublich viel" assumed a boy. Now
    "dem Kind".
  • Prayer commitment: "regelmäßig" → "regelmässig" (the file uses Swiss spelling).

Swiss French (fr_CH)

  • "Code" (postal code) read "Réf. Enfant". Now "NPA".
  • Logged-in thank-you page: the preferences paragraph had lost its leading period, so it ran into
    the previous sentence ("…avec Anna Pour une expérience…").
  • "All set" first-letter prompt: "pourquoi ne pas envoyer à un premier bonjour".

Italian (it_IT)

  • "Code" (postal code) read "Codice". Now "NPA".
  • "Salutation" (the Mr/Mrs field) read "Saluto" (a greeting). Now "Titolo".
  • Preferences paragraph: leading period restored (same issue as French).
  • Sponsorship Plus modal: the amount keeps its ".-" suffix like the other amounts there.

Swedish (sv_SE)

  • "Salutation" read "Hälsning" (a letter greeting). Now "Tilltal".
  • Payment page: "fadderskap av " → "fadderskap för ".
  • Details form: "innan sitt första brev" used a reflexive that points at "vi". Now "före det
    första brevet".

Norwegian (nb_NO): "fadderskapet ditt av " → "for "; same reflexive fix in the
details form ("før det første brevet").

Danish (da_DK): "fadderskab af " → "for ".

Finnish (fi_FI): "All set, " read "Valmista, ". Now "Kaikki valmista, ".

Texts untranslated in every language (sv, nb, fi, de, fr_CH, it; Danish already had them in
#387): the terms-and-conditions consent label shown when the website has a terms page ("I accept
the terms and conditions and the privacy policy."), its error message, and "Your payment did not
go through. Please try again, or use another card." Each uses the language's existing words for
privacy policy, and its usual form of address (German du, French vous, Italian tu).

Broken markup and placeholders (second commit; these were already on 18.0)

  • German: both "Someone else has decided to sponsor {child_name}…" texts printed the child's name
    twice. The second one is now a pronoun ("für ihn und seine Familie" / "für sie und ihre
    Familie"), so {child_name} appears once, as in the source.
  • German: the sponsor-a-child page text ending in three <br/> had lost them. They are back.
  • Swiss French: the sponsorships-page explainer wrote "Write & Pray" with a bare &, which is not
    valid XML (Odoo repairs it when it renders the page). It now uses Write&amp;Pray, as the source does.
  • German, Swiss French, Italian: "Account could not be deleted, please contact us. " and the
    letter-template cron name keep the source's trailing space.

Checks

  • msgfmt --check-format clean on all seven files; pre-commit passes.
  • po_qa.py (odoo-i18n skill): 0 hard problems in all seven files (before: de 5, fr_CH 4,
    it 2). No new soft finding; the other changes in its report are six fewer empty entries per
    language and one fewer dropped entity in French.
  • -u my_compassion on a copy of the Nordic database with the first commit: exit 0, no ERROR.

Needs a native check

The newly filled texts (consent label, its error, failed-payment message) in sv, nb, fi, de,
fr_CH and it, the reworded German payment sentence, and the German "ihn / sie" in the
child-unavailable texts.

German: the postal-code field is labelled PLZ instead of a child reference.
The payment-page description is a complete sentence again (Bezahle den
ersten Monat und starte deine Patenschaft für <name>). The first-letter
prompt says dem Kind instead of ihm, since it serves girls and boys. The
prayer commitment uses the Swiss ss spelling like the rest of the file.

Swiss French: the postal-code field is labelled NPA instead of a child
reference. The preferences paragraph keeps the leading period that closes
the sentence before it. The first-letter prompt reads envoyer à <name>.

Italian: the postal-code field is labelled NPA, Salutation is Titolo, the
preferences paragraph keeps its leading period, and the Sponsorship Plus
amount keeps its .- suffix.

Swedish: Salutation is Tilltal (Hälsning is a greeting). The payment page
says fadderskap för <name>, and the details form no longer uses a
reflexive possessive that pointed at the wrong subject.

Norwegian: fadderskapet ditt for <name>, and the same reflexive fix in the
details form. Danish: fadderskab for <name>. Finnish: All set, <name>
reads Kaikki valmista.

Swedish, Norwegian, Finnish, German, Swiss French and Italian also get the
texts that had no translation in any of them: the terms-and-conditions
consent label, its error message, and the failed-payment message.

Assisted-by: claude-opus-5-5, xhigh, claude-code
…CH, it

German: both "Someone else has decided to sponsor {child_name}" texts printed
the child's name twice; the second one is now a pronoun (ihn / sie), so
{child_name} appears once, as in the source. The sponsor-a-child page text
that ends with three line breaks had lost them in German; they are back.

Swiss French: the sponsorships-page explainer wrote Write&Pray with a bare
ampersand, which is not valid in a view translation; it now uses the
entity, as the source does.

German, Swiss French and Italian: "Account could not be deleted, please
contact us." and the letter-template cron name keep the source's trailing
space.

Assisted-by: claude-opus-5-5, xhigh, claude-code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant