Repository navigation
Conversation
German: the postal-code field is labelled PLZ instead of a child reference. The payment-page description is a complete sentence again (Bezahle den ersten Monat und starte deine Patenschaft für <name>). The first-letter prompt says dem Kind instead of ihm, since it serves girls and boys. The prayer commitment uses the Swiss ss spelling like the rest of the file. Swiss French: the postal-code field is labelled NPA instead of a child reference. The preferences paragraph keeps the leading period that closes the sentence before it. The first-letter prompt reads envoyer à <name>. Italian: the postal-code field is labelled NPA, Salutation is Titolo, the preferences paragraph keeps its leading period, and the Sponsorship Plus amount keeps its .- suffix. Swedish: Salutation is Tilltal (Hälsning is a greeting). The payment page says fadderskap för <name>, and the details form no longer uses a reflexive possessive that pointed at the wrong subject. Norwegian: fadderskapet ditt for <name>, and the same reflexive fix in the details form. Danish: fadderskab for <name>. Finnish: All set, <name> reads Kaikki valmista. Swedish, Norwegian, Finnish, German, Swiss French and Italian also get the texts that had no translation in any of them: the terms-and-conditions consent label, its error message, and the failed-payment message. Assisted-by: claude-opus-5-5, xhigh, claude-code
…CH, it
German: both "Someone else has decided to sponsor {child_name}" texts printed
the child's name twice; the second one is now a pronoun (ihn / sie), so
{child_name} appears once, as in the source. The sponsor-a-child page text
that ends with three line breaks had lost them in German; they are back.
Swiss French: the sponsorships-page explainer wrote Write&Pray with a bare
ampersand, which is not valid in a view translation; it now uses the
entity, as the source does.
German, Swiss French and Italian: "Account could not be deleted, please
contact us." and the letter-template cron name keep the source's trailing
space.
Assisted-by: claude-opus-5-5, xhigh, claude-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T3423 — Translation errors found in review (my_compassion)
Why
The review of #387 checked the translations of the new-sponsorship pages in every language.
Most problems it found are older than #387 (the same text is on 18.0). This PR fixes only the
ones that are plainly wrong for the reader. Wording and style preferences are left alone.
What changed
Only
msgstrvalues inmy_compassion/i18n/*.po. No code, no template, no manifest change.German (
de_DE)(a child reference). Now "PLZ".
Now "Bezahle den ersten Monat und starte deine Patenschaft für ."
"dem Kind".
Swiss French (
fr_CH)the previous sentence ("…avec Anna Pour une expérience…").
Italian (
it_IT)Swedish (
sv_SE)första brevet".
Norwegian (
nb_NO): "fadderskapet ditt av " → "for "; same reflexive fix in thedetails form ("før det første brevet").
Danish (
da_DK): "fadderskab af " → "for ".Finnish (
fi_FI): "All set, " read "Valmista, ". Now "Kaikki valmista, ".Texts untranslated in every language (sv, nb, fi, de, fr_CH, it; Danish already had them in
#387): the terms-and-conditions consent label shown when the website has a terms page ("I accept
the terms and conditions and the privacy policy."), its error message, and "Your payment did not
go through. Please try again, or use another card." Each uses the language's existing words for
privacy policy, and its usual form of address (German du, French vous, Italian tu).
Broken markup and placeholders (second commit; these were already on 18.0)
twice. The second one is now a pronoun ("für ihn und seine Familie" / "für sie und ihre
Familie"), so
{child_name}appears once, as in the source.<br/>had lost them. They are back.&, which is notvalid XML (Odoo repairs it when it renders the page). It now uses
Write&Pray, as the source does.letter-template cron name keep the source's trailing space.
Checks
msgfmt --check-formatclean on all seven files; pre-commit passes.po_qa.py(odoo-i18n skill): 0 hard problems in all seven files (before: de 5, fr_CH 4,it 2). No new soft finding; the other changes in its report are six fewer empty entries per
language and one fewer dropped entity in French.
-u my_compassionon a copy of the Nordic database with the first commit: exit 0, no ERROR.Needs a native check
The newly filled texts (consent label, its error, failed-payment message) in sv, nb, fi, de,
fr_CH and it, the reworded German payment sentence, and the German "ihn / sie" in the
child-unavailable texts.