Repository navigation
Integrate dossiq batch b44: decision letter, payment and term labels, colleague party, case objects, access purpose - #4672
Merged
Merged
Conversation
The board draws a muted line under the rows: once signed the letter cannot change, and the six-week objection period starts on the day it is announced. The card carries it as the facts widget's footnote (nextcloud-vue feat/facts-footnote; without it the line is not drawn). Assisted-by: ClaudeCode:claude-opus-5-5
With the origin pills, the grip and the one-line head controls the fields table ran to its one-line width (916px probed against a 754px card). It now fits the card (`fitWidth`), every column at its content and the field name wrapping (`cn-cell--wrap`), so it takes the table's smallest width, as DqZaaktypeVelden draws it. Assisted-by: ClaudeCode:claude-opus-5-5
paymentState gets x-enum-labels (case 1.53.0), so Termijn en betaling reads "Geen leges voor dit zaaktype" rather than the stored code. Assisted-by: ClaudeCode:claude-opus-5-5
The colleague schema had no surface (SchemaHasSurfaceTest). Board DqZaakBetrokkenen draws "Partij toevoegen" on the case parties card, so the card gets manage.add with residents, organisations and colleagues as picker sources; the role is one the case declares. Config only. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
The decision letter drafted from the case type's template (documentDrafts)
is linked to the case like any document, so the review counted it: one
more document to assess ('4 van 8') and outstanding in the decide dialog.
The review corpus now leaves out every document whose type is one of the
case type's drafted document types (by name or catalogue id), for every
purpose. Driven by the case type's declaration, nothing Woo-specific.
Assisted-by: ClaudeCode:claude-opus-5-5
…arket pitches Nine caseObject rows link the two felling permits, the neighbourhood party, the spring-rider report and the market-pitch objection to their objects in OpenRegister's public-space register, so the object type catalogue lists Boom, Speeltoestel and Standplaats with their schema. Assisted-by: ClaudeCode:claude-opus-5-5
The case carries its type's extension period (case 1.54.0), and the term card reads "Wettelijke termijn: 4 weken, te verdagen met 2" and "Laatst gecontroleerd" through nextcloud-vue's duration format. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
… follows fit-card term-and-payment-board-labels adds case.statutoryExtension without a search declaration (caseSearchDeclarations): exact text, as statutoryTerm. case-type-fields-fit-card wraps the Field column. Assisted-by: ClaudeCode:claude-opus-5-5
DQ-L7 gave the colleague schema its surface (b165500, an Add party action on the case parties card); its two new commits merge next. Assisted-by: ClaudeCode:claude-opus-5-5
colleague-party took case 1.53.0 first (b43, re-landed here), so the payment state labels move to 1.54.0 and the statutory extension to 1.55.0 (fragments, notes, proposals, digest records). Each still moves past the version before it. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
… documents Passing CaseDocumentDrafts through WOODocumentAssessmentService raised its coupling to 13 (phpmd). It now takes the review's OutstandingDocuments as the container builds it, which already carries the drafted document types, and builds one itself only without it. Assisted-by: ClaudeCode:claude-opus-5-5
…nto integrate/dq-b44
…jects
ObjectTypeSchemaResolver also counts the objects the register holds in the
schema (null when the count fails), and each catalogue row carries
objects and schemaLine, the schema title with the count in the reader's
language ("Bomenregister · 5 objecten"). The Objecttypen table's line
under the type reads schemaLine.
Assisted-by: ClaudeCode:claude-opus-5-5
Board DqZaakGerelateerd lists the cycle path (BGT wgl.0505.1234) before the masts LM-0014 and LM-0015, which is the identification order. Assisted-by: ClaudeCode:claude-opus-5-5
…ialog
Ruben, 26 Oct (DQ-ZERO "the access-purpose modal"):
- GET /api/cases/{id}/access-purpose answers whether the reader must
state a purpose. A reader who holds a configured generic role on the
case (default handler: the assignee or a handler role binding) does
not: the configured purpose (default handling) is recorded for them,
marked automatic, and the case page opens without the dialog
(nextcloud-vue accessPurpose.checkUrl).
- The dialog's intro says it shows because the reader is not this
case's handler.
- A purpose can bind the reader to a generic role (default handling ->
handler): after the purpose, a role binding is added with the case
type's own role type for that generic role, else a shared one, and a
second trail entry dossiq.case.access-role says so. The option says it
before the reader confirms (options[].hint).
- The rules are app config access_purpose_roles (AccessPurposeRules),
not procedure code. User docs explain the dialog.
openspec change access-purpose-handler. Needs nextcloud-vue
feat/access-purpose-check-and-option-hint (schema 2.157.0).
Assisted-by: ClaudeCode:claude-opus-5-5
…o count The catch-return-null ratchet allows no new swallowing catch, and the catalogue already lets a refused read fail the endpoint (503) rather than show a wrong number. Assisted-by: ClaudeCode:claude-opus-5-5
…nto integrate/dq-b44
…allowing check:strict: CaseRoleHolder::rows() caught a failed search and answered [], a new swallowing catch against the ceiling (ServiceCatchReturnsNull). The lookup now throws, and the access-purpose service decides what a failure means: the reader is asked for a purpose (the safe side), and a binding that could not be made leaves the recorded purpose and the open case as they are. Both are logged at warning. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 26, 2026 10:24
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ❌ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ✅ | ✅ 109/109 | |||
| npm | ❌ | ✅ 658/658 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-26 10:35 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dossiq batch b44:
It builds on development after b43 (#4669). Known dependency: r32/access-purpose-handler adds
accessPurposeto the CaseDetail page config. That needs nextcloud-vue schema 2.157.0 from 24t2a (feat/access-purpose-check-and-option-hint 8aac5b1a21). Against development's nextcloud-vue (2.143.0, schema 2.155.0), check:manifest refuses those keys. This is the 24t2a dependency, not a defect; :8080 builds against 24t2a, and the bump follows that release.Heads (merge order, --no-ff)
r33/decision-letter-footnote11d1093r31/case-type-fields-fit-cardaf830d7r31/case-payment-state-labels310a3d9r31/term-and-payment-board-labels02a451ffeat/colleague-partyb165500r34/review-skips-drafted-letters7adb3f1feat/exset-case-objects-link-public-space8ba282bfeat/exset-case-objects-link-public-space6213d7afeat/catalogue-object-counta78d22fr32/access-purpose-handler0c11d24Integration changes
searchable: false.case.statutoryExtensiongets a search declaration (exact match, text input, asstatutoryTerm), and its two schema texts get catalogue keys.Verified locally
validate-manifestagainst development's nextcloud-vue (schema 2.155.0): FAIL on exactly two errors,/pages/6/config/accessPurposeand/pages/6/config/accessPurpose/options/0(additionalProperties). That is the known 24t2a dependency (schema 2.157.0).accessPurposekeys: the three built-manifest schema checks (landingViews, simpleCasePage, simpleListAndDashboard) and four validateManifestLag cases, whose check:manifest run exits 1 on them. No other red.COMPOSER_PROCESS_TIMEOUT=0 composer check:strict, run alone: ALL CHECKS PASSED, exit 0. PHPUnit: 9910 tests, 0 errors, 0 failures.Prepared by a dossiq integration lane (AI-assisted, Claude Code); the coordinator merges.