Skip to content

feat(example-sets): public-space register (openbare ruimte) in the Zuiddrecht set - #4891

Merged
rubenvdlinde merged 2 commits into
developmentfrom
feat/exset-public-space-register
Oct 26, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
feat/exset-public-space-register

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What

A public-space register (openbare ruimte) for the Zuiddrecht example set, so dossiq cases can link a real object with a name and status of its own (Ruben's decision c, 26 Oct).

  • lib/Settings/public_space_register.json: a mock descriptor (x-openregister.type: mock), so no instance imports it unless a set requires it. Register public-space, title "Openbare ruimte", five schemas whose titles are what dossiq's object type catalogue shows under each type:
    • tree "Bomenregister", 9 properties, with a geo location (Kaart, Tabel)
    • street-light "Openbare verlichting", 7 properties, geo
    • play-equipment "Buitenruimte", 11 properties, geo
    • market-pitch "Markt", 6 properties, no geo (Tabel)
    • road-section "Wegen en paden", 6 properties, geo
  • lib/Settings/example-sets/zuiddrecht.json: requires gains {"register": "public-space", "mock": true}, and OpenRegister's fragment adds 13 objects (5 trees, 4 street lights, 1 spring rider, 2 market pitches, the Lindelaan cycle path). Other fragments find them by identification.

Configuration and data only, no code. Slugs and property names are English; titles and values are Dutch, as the boards draw them.

Used by

Merge this one first.

Verified

  • New ZuiddrechtPublicSpaceTest (4 tests); ExampleSetCatalogueTest and ExampleSetMockRegisterImportTest updated, the latter imports every required register, the new mock included, on a fresh instance double. EveryCoreRegisterIsImportedTest, RegisterDescriptorServiceTest, tests/validate-register.js and validate-json-strict.js pass.
  • diff-check: php -l, phpcs, phpunit green on the touched lines. The gates runner timed out at 300 s with 0 gate lines (whole-tree read), so gates did not run.
  • composer check:strict once: lint, psalm, phpstan clean. Inherited: phpmd UnusedPrivateField in lib/ files this PR does not touch, and 18 PHPUnit errors (15 in tests/Unit/Db, OC\DB\QueryBuilder\CompositeExpression outside a server tree; 2 SourcesControllerTest; 1 DbalObjectSourceProviderTest). The one failure in that run was mine (ExampleSetMockRegisterImportTest expectation) and is fixed in the second commit; that file was re-run alone, not the whole suite.

Not installed on :8080 by this lane; the refresh lane applies the set with --refresh.

Assisted-by: ClaudeCode:claude-opus-5-5

…iddrecht set

A mock descriptor declares register public-space with five schemas (tree,
street-light, play-equipment, market-pitch, road-section); the Zuiddrecht
cast file requires it and fills it with 13 objects that dossiq and portaliq
cases link to by identification. A mock is imported only when a set asks.

Assisted-by: ClaudeCode:claude-opus-5-5
…mock

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ cd559e9

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
test-l10n ✅
test-l10n-parity ✅
format ❌
check-schema-l10n ❌
composer ✅ ✅ 173/173
npm ❌ ✅ 648/648
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-26 09:55 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant