Repository navigation
feat(example-sets): public-space register (openbare ruimte) in the Zuiddrecht set - #4891
Merged
Merged
Conversation
…iddrecht set A mock descriptor declares register public-space with five schemas (tree, street-light, play-equipment, market-pitch, road-section); the Zuiddrecht cast file requires it and fills it with 13 objects that dossiq and portaliq cases link to by identification. A mock is imported only when a set asks. Assisted-by: ClaudeCode:claude-opus-5-5
…mock Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ❌ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-26 09:55 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A public-space register (openbare ruimte) for the Zuiddrecht example set, so dossiq cases can link a real object with a name and status of its own (Ruben's decision c, 26 Oct).
lib/Settings/public_space_register.json: a mock descriptor (x-openregister.type: mock), so no instance imports it unless a set requires it. Registerpublic-space, title "Openbare ruimte", five schemas whose titles are what dossiq's object type catalogue shows under each type:tree"Bomenregister", 9 properties, with ageolocation (Kaart, Tabel)street-light"Openbare verlichting", 7 properties, geoplay-equipment"Buitenruimte", 11 properties, geomarket-pitch"Markt", 6 properties, no geo (Tabel)road-section"Wegen en paden", 6 properties, geolib/Settings/example-sets/zuiddrecht.json:requiresgains{"register": "public-space", "mock": true}, and OpenRegister's fragment adds 13 objects (5 trees, 4 street lights, 1 spring rider, 2 market pitches, the Lindelaan cycle path). Other fragments find them byidentification.Configuration and data only, no code. Slugs and property names are English; titles and values are Dutch, as the boards draw them.
Used by
Merge this one first.
Verified
ZuiddrechtPublicSpaceTest(4 tests);ExampleSetCatalogueTestandExampleSetMockRegisterImportTestupdated, the latter imports every required register, the new mock included, on a fresh instance double.EveryCoreRegisterIsImportedTest,RegisterDescriptorServiceTest,tests/validate-register.jsandvalidate-json-strict.jspass.composer check:strictonce: lint, psalm, phpstan clean. Inherited: phpmd UnusedPrivateField in lib/ files this PR does not touch, and 18 PHPUnit errors (15 in tests/Unit/Db,OC\DB\QueryBuilder\CompositeExpressionoutside a server tree; 2 SourcesControllerTest; 1 DbalObjectSourceProviderTest). The one failure in that run was mine (ExampleSetMockRegisterImportTestexpectation) and is fixed in the second commit; that file was re-run alone, not the whole suite.Not installed on :8080 by this lane; the refresh lane applies the set with
--refresh.Assisted-by: ClaudeCode:claude-opus-5-5