Repository navigation
fix(example-sets): public-space locations are objects with format geo:point - #4895
Merged
Merged
Conversation
…:point
"type": "geo" is not a JSON Schema type, so the validator refused every
public-space object ("type contains invalid json type: geo") and with them
the Zuiddrecht set. A location is now {"type": "object", "format":
"geo:point"}, the spelling GeoJsonGeometryValidator reads. A test runs
ValidateObject and the GeoJSON check over all 13 objects.
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ❌ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-26 10:58 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
Oct 26, 2026
…ted again (#4897) An example set skipped every required register already on the instance, so a schema fixed in the descriptor (public-space location type geo to object + format geo:point, #4895) never reached an instance that had installed the set. The set now re-imports a required register when its descriptor ships a newer version than the instance holds (RegisterDescriptorService::isBehind), and the public-space register and its four changed schemas move to 1.0.1. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
REFRESH-7 refused the whole Zuiddrecht set:
public_space_register.json(#4891) declared its locations as"type": "geo", which is not a JSON Schema type. The Opis validator threw "type contains invalid json type: geo" for every public-space object (11 refusals).The
locationproperty of tree, street-light, play-equipment and road-section is now{"type": "object", "format": "geo:point"}. That is the spellingGeoJsonGeometryValidatordocuments as the one a JSON Schema validator accepts, and it still runs the GeoJSON point check. Nothing else in the descriptor changed.Test
ZuiddrechtPublicSpaceTest::testEveryObjectPassesTheValidatorrunsValidateObject::validateObject()andGeoJsonGeometryValidator::validateObject()over all 13 public-space objects of the cast file.InvalidKeywordException: type contains invalid json type: geo.The schema-shape test now detects the location by
format: geo:point.Verified
tests/Unit/Service/ExampleSetpasses (270 tests), and so doestests/Unit/Settings(35 tests).validate-register.jspasses.composer check:strictwas not re-run for this urgent JSON-and-test fix. feat(example-sets): public-space register (openbare ruimte) in the Zuiddrecht set #4891's run is the baseline.The dossiq catalogue read only
type: geofor its Kaart view. The companion headfix/object-views-read-geo-format(5b6c07972) reads a geo type or format, so Boom, Lantaarnpaal, Speeltoestel and Wegen en paden keep "Kaart, Tabel".Assisted-by: ClaudeCode:claude-opus-5-5