Repository navigation
Centre onboarding's pictures on a desktop, and draw every Bot as a Duet orb - #80
Merged
Merged
Conversation
…et orb Two things wrong at desktop width in onboarding. Bring the agents you already have showed the brief demo left of centre over a frame of frameworks right of it. IllustrationFrame caps itself at max-w-lg and was centred only by the column around it; the capability demo wraps it in a full-width box, where it sat at the left edge. It now centres itself. Pick a Bot drew OpenDuet as its orb and every other Bot as a pink gradient disc, which read as another product. The orb now has the four colours the launch film's title uses: Ocean, OpenDuet's own, plus Ember, Lime and Graphite. Every other Bot wears one of those three, picked from its id so it is the same colour in the roster, its profile and the conversation list.
…olours With the running * 31 hash, your-agent, support-desk and the onboarding roster's ids all landed on one colour, so the roster read as OpenDuet beside two identical Bots.
Collaborator
Author
|
Security review: no actionable findings. This is presentation only: a CSS centring fix and avatar drawing. No data, routes or permissions change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Two things looked wrong at desktop width in onboarding:
The approach
Centring.
IllustrationFramecaps itself atmax-w-lg. Placed straight in a step's centred column, it was centred by that column. But the capability demo wraps it in a full-width box, and there it sat at the box's left edge. The frame now centres itself (mx-auto).The orb's colours. The mic orb now has the four colours the launch film's title uses, taken from
launch-film/film/src/duet/micorb.ts:MicOrbtakes acolour, and the palette carries the rim shade per colour. Every Bot other than the tenant's own now wears one of the other three, in bothAbstractAvatar(roster, profiles, cards, hand-off) and the conversation list'sChannelAvatar.The colour is picked from the Bot's id with FNV-1a, so a Bot is the same colour everywhere. FNV-1a replaced a running
* 31hash, which putyour-agentand the onboarding roster's ids all on one colour.AbstractAvatar'sseedis now optional and unused, because the conversation list only has the id.What is not covered
boring-avatarsis no longer imported by the app. I left it inpackage.jsonto keep the lockfile out of this change.Verification
bun test app/tests: 2430 pass, 0 fail.tenant-bot-avatar.test.tsxchecks that:bun run typecheckis clean, and Biome lint is clean.