Repository navigation
Batch Discussion overlap reads with complete pagination - #2493
Mister-Meeseeks merged 1 commit into
Conversation
|
Independent finite audit of this exact head ( A separately implemented static API model and direct traversal corroborate the complete ordered records on 710 distinct graphs (2,062,777 records per collector). The added failure audit injects three error types at every request position on a busy graph, with and without previous evidence: 810 baseline and 504 candidate cases. All preserve the original complete Discussion source/timestamp or publish no first-fetch partial source. Source corruption and early-listing/comment/reply mutants reject. Your six original tests pass unchanged in normal and optimized processes. Registered Windows x64 / CPython 3.12.14 normal and optimized replays pass; an optimized Git-free/path-with-spaces replay preserves every package file. The fixed small-thread corpus corroborates 104 to 3 requests. This is finite assisted verification, not a new timing measurement or independent human review. The implementation, original tests and benchmark remain credited to Arham Garg and the retained overlap-tool lineage. I also reproduced both reported dependent-package metadata errors on untouched main. Their integration/source-binding disposition remains separate; this audit does not alter frozen evidence or adopt the collector. CI for #2797 is queued, with no hosted success claimed. Canonical result and released claim. Prepared for Arham Tahir with substantial OpenAI Codex assistance; Apache-2.0. No issue found within this audit's explicit finite domain. |
Discussion scans currently make a separate comments request for every thread, including empty threads. This change includes the first five comments and replies in each 50-thread listing and exhausts the remaining cursors in 100-item pages. It preserves ordered records, search behavior, cache lifetime and replacement only after a complete fetch.
On the same 20 public Discussions, three alternating before/after pairs returned all 77 records with identical hashes. Requests fell from 21 to 2 per run; median wall time fell from 18.44 to 2.63 seconds, with ranges 17.64–18.52 and 2.59–3.25 seconds. The evidence package includes the runnable opt-in benchmark, every measurement, source pins and an offline replay.
Validation on Python 3.12.13, macOS arm64:
uv run --python 3.12 --no-project python -B -m unittest discover -s tests -p 'test_research_*.py' -v: 71 tests, 68 passed and three Linux-only checks skipped.uv run --python 3.12 --no-project python -B scripts/research_package.py --package research/overlap-discussion-batching: six coverage tests pass normally and under-O; metadata/source checks pass.53 != 2. Stopping either comment or reply pagination causes the CLI coverage test to fail. Later-page errors preserve old complete evidence and its timestamp.git diff --checkand the selected source-binding baseline pass. The final live overlap scan covered 687 open PRs and 1,199 Discussion records with complete pagination and no warnings.This is a draft because two affected older replay packages fail their frozen source checks on both untouched main and this branch.
overlap-path-indexreports a source-blob provenance mismatch;research-package-pin-batchingreports onboarding-test drift. This patch also changes the onboarding bytes pinned by the first package. The README records exact commands and errors. Their pins remain unchanged under repository guidance; integration needs a maintainer source-binding decision. Aaron Wang's PR2255 documents the broader existing issue.The task picker selected verifier engineering,
replay-runtime, at priority revision 4. TASK.json declares the change in scope to the required overlap step, prompted by measured scan cost and public stall reports. Base is0fdd7d82de03e43c9e5a1000dfbcd380d1b687d2. Coordination is in Discussion2264. PR2154 changes task-term extraction and is a distinct contribution, with no dependency.Timing is corpus and environment dependent. GitHub pagination remains non-atomic during concurrent edits; very busy threads may need an extra continuation. No full supplier replay, Linux timing, mathematical advance or selected-frontier change is claimed. No existing files or functions were deleted. Hosted CI has been triggered and remains queued as of 2026-10-15 12:43 UTC. No remote check is claimed as passing; the registered-package run selects this package and the two frozen dependents above.
Credit to Douglas Colkitt and the overlap-tool contributors, including Nick Petalas's pagination compatibility repair. Prepared by Arham Garg with substantial OpenAI Codex assistance, GPT-6 Astra, for implementation, verification and writing. No independent review is claimed. Apache-2.0.