Skip to content

Honest rare counts in pack summaries + one-tap set switching - #29

Merged
DLinacre merged 1 commit into
mainfrom
arena/66675182-pokeguru
Nov 14, 2026
Merged

DLinacre merged 1 commit into
mainfrom
arena/66675182-pokeguru

Conversation

@DLinacre

Copy link
Copy Markdown
Owner

The bug in the screenshots

A 36-pack Base Set rip reported "0 rare or better" while showing a Charizard. Not a display glitch in the Top 100 and not a Top-100 filter: the summary only counted double rare and above, and a base-set Charizard is printed as a plain rare, so it was thrown away by the counter even though it was the best card of the opening.

Counting is now derived from the cards you actually pulled

  • pullCounts() replaces the ad-hoc filtering. Notable pulls are rare or better — those are what the summary now shows as artwork, rarest first, in a new HighlightStrip (single pack and batch).
  • The chase count uses each era's own threshold: double rare+ for modern sets, holo rare+ for Wizards/older sets. A Base Set opening never gets labelled with a modern chase tier.
  • Labels name the threshold and say "No holo rare or better" rather than a bare 0, which read like a bug.
  • The header states the count at both levels (396 cards · no rare or better / 36 packs · 2 double rare or better), the stat tile shows chase hits with a "+n more rare or better" line, and each pack row reports how many notable cards that pack held.
  • The empty state explains the Base Set case in plain words, so the next person does not think the sim is broken.

Changing what you rip is now one tap

  • PackPicker strip on the setup screen and above the opening stage: current set first and checked, recently used sets next, one tap to switch — and the pack count is carried across.
  • QuickRip under the summary: repeat this set at 1 / 5 / box size with a single press, or jump straight into another expansion at the same count. Replaces the old generic repeat buttons.

Verification

  • npm test — 25 files / 210 tests pass, including new coverage for the base-set Charizard case, era-specific chase thresholds, the highlight strip, quick-rip counts and cross-set links.
  • npm run lint, npm run typecheck, npm run build all clean.

The batch summary counted only double-rare-and-above, so an opening that
contained a base-set Charizard (printed as a regular rare) reported
"0 rare or better" next to the card itself. That read like a bug.

Counting
- pullCounts() now derives everything from the drawn cards: notable pulls are
  rare-and-above (shown as artwork), and the chase count uses the era's own
  threshold (double rare+ in modern sets, holo rare+ in older ones) so a
  Wizards-era opening never claims a modern chase tier.
- Badges and the stat tile name the threshold and say "No ..." instead of a
  bare 0, and the header states how many cards hit each level.
- New HighlightStrip shows the actual rares as faces, rarest first, in both
  the single-pack and batch summaries.
- Per-pack rows report how many notable cards that pack contained.

Ripping a different set
- New PackPicker strip on the setup screen and above the opening stage:
  current set first and checked, recent sets next, one tap to switch, keeping
  the chosen pack count.
- New QuickRip block under the summary: repeat this set at 1/5/box with one
  press, or jump straight into another expansion at the same count.
- The summary's generic repeat buttons are replaced by those two rows.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@DLinacre
DLinacre merged commit e0e93a3 into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant