Repository navigation
Conversation
|
Thank you for this. The text514 codec is careful, and the field list matches the published structure: we checked the VšZP Before this can merge, there is one design question, plus a few points that depend on its answer. Design
Correctness
Tests (coverage measured on the touched modules, 89% overall)
Conventions
Size
|
|
Review follow-up: shared fund records Thank you for the detailed engine and published-format checks. I reproduced three calendar/profile cases on the public source: a reviewed calendar dropping version disability, a minimum opt-out without calendar concurrency, and health contributions on a student agreement. The three regressions fail before the fix; the first local correction passes 33 health calculation tests. This is not the full review resolution yet. I am reshaping #34 into the shared per-fund recorded-base mechanism, with health as the first fund, one declaration accessor, and the requested monthly-original warning fallback versus corrective/ELDP refusal. The existing precise historical evidence will remain readable without rewriting confirmed payslips. #37 will consume this same mechanism for social funds rather than introduce a second recording design. The reviewed calendars and text514 path will be split into their own dependent contributions. XML will remain usable without the recorded-base adapter, and engine-specific fixtures will be kept separate from engine-neutral tests. I will leave the Enterprise bridge to you as offered. I have also started the independent #35 fixes: explicit assertion language, cleanup of Enterprise payroll-note dependencies belonging only to the test's own company, muted expected serialization errors, the conventional schema pin, and Czech verified metadata. The first registration batch passes 30 Community tests; this does not claim an Enterprise run. The remaining source guards, storage-migration workflow, 2P/2S policy, catalogue/style pass and documentation hooks are being handled with the corresponding split. |
|
Broader contribution roadmap and architecture alignment To make the final direction clearer beyond the individual reviews: the intended contribution is to fill gaps in standard Slovak company accounting and payroll in this repository, using its existing applications as the foundation. It is not a replacement payroll engine or a second accounting ledger. I would like to agree on the extension boundaries early, rather than submit large changes that diverge from this repository's architecture or Enterprise bridge. The remaining work is grouped as follows; this is a roadmap, not a claim that these features are complete:
The immediate implementation remains the A/B/C split you requested, rather than expanding #34 again. Local review fixes and tests will be carried over, but I am not treating their current passing results as verification of the reshaped architecture or of Enterprise. Could you flag any of these workstreams that overlap existing functionality or planned work for this repository, so I can avoid duplication? In particular, does the proposed ownership of the shared fund schema/accessor and bridge storage match your intended architecture, and should the replacement fund-core PR supersede #34 with B/C as dependent PRs? Also, should documentation-topic registration be supplied as a snippet since I will continue the agreed shared fund implementation while these questions are open, and keep the remaining pieces small enough to review by responsibility. Your direction on module boundaries and ordering will take precedence over the tentative roadmap. |
|
Thank you for laying this out. The direction matches ours, and agreeing the boundaries now is the right order. Answers to your questions: 1. Ownership of the shared fund records. Yes, that's the architecture we want:
Please keep the engine-neutral tests in the base and the engine-specific fixtures in each bridge. Pin message-matching tests to 2. Ordering. Yes. Open the fund core as a new PR that references #34 and #37, and close #34 once it is up. Then the reviewed calendars (B) and the 514 format and declaration (C) as dependent PRs, with #35 rebased on C. Keep the confirmation and locking changes from #37 in their own PR, as you planned. 3. Overlap with what already exists. Please build on these rather than alongside them:
4. Guide topics. One change to the policy from #25: ELDP falls back to gross with the warning, like the monthly originals, instead of refusing. ELDP is now only for periods before 2026 (#41), and those payslips will never carry fund records, so a refusal would block every remaining ELDP, including the one-off § 293gl filings due by 31 December 2026. Corrective filings still refuse. #42 is reviewed separately; we'll merge it. |
|
Superseded by #43 for shared fund core A, following the agreed ordering. Reviewed calendars B and the 514 codec/declaration C are retained for dependent contributions; #35 will be rebased on C. Confirmation/source locking remains separate. Closing this combined proposal as requested once the new core is up. |
The legacy health statement reconstructs employee bases and rates from GROSS and rounded premiums, puts everyone in one disability group, and cannot represent the published minimum-top-up/OP fields correctly. This adds a current text514 path driven by the same assessment facts as payroll.
The base module provides the common OP/base calculation and reviewed monthly insurance calendars. Calendar intervals distinguish employment, actual 2D work/rest days, the single 2Y day, benefit days and minimum exceptions. Reviews and revisions retain their original facts, reviewer and time; company rules, protected API/default paths and parent locks cover changes to both headers and children.
The OCA adapter uses those facts for employee premiums, disability rates and the monthly minimum. Computed payslips retain their original insurer, income category, actual rates, bases, premiums and calendar source. The declaration verifies all matching monetary lines instead of trusting the first row of a repeated rule code. Later employee-card edits do not silently reclassify a historical source.
The native health workflow offers the insurer-published 2023+ UTF8 text format with both disability groups, OP/other income, the separate employee top-up, original N and full corrective O filings. It keeps the existing XML API default and the common generate/reset/filed-attachment workflow. Two small declaration-base hooks supply format-specific attachment metadata and a truthful validation message. Existing filed bytes remain available after corrections. A superseded calendar requires a payroll-source review before new generation.
Validation:
Follow-up concurrency audit reproduced a stale calendar review after a committed child-only edit. The parent now advances a non-key version so PostgreSQL retries the stale transaction. All57 base tests pass, including the real two-transaction case; earlier237/928 counts below precede this additional guard and must not be presented as its regression.
237 native tests pass on the public modules without private adapters.
Ordinary stock payroll Officer HTTP workflow passes twice: actual UI onchange, calculation, confirmation, TXT download, calendar review/revision and loaded Slovak fields/Python errors. The stock Officer group implies HR Manager; this was not tested as system administrator or Payroll Manager.
928 tests pass in the shared payroll assembly with its installed accounting, corrections, annual-tax and employment adapters. That assembly includes separately tested pending sickness/average fixes; the clean public run above excludes private adapters.
Native Odoo POT export, full Slovak merge, Ruff 0.13.0 and diff whitespace checks pass. Canonical English/Slovak documentation is updated; the generated documentation site was not rebuilt because its source generator is not published here.
Scope is explicit: this does not submit 601 notices, fabricate legacy assessment evidence, automatically build additive corrections or consolidate multiple independent correction sources into a single employee-month. Those need their corresponding source adapters. Calendar review is factual HR evidence, not proof of submission to an insurer. The new payroll integration was verified with the OCA engine; the engine-neutral source alone does not establish an Enterprise integration.
Primary interfaces and interpretation: published514 text specification, Health Insurance Act, insurer minimum-advance guidance.