Repository navigation
Conversation
…t replace archive
|
Thanks. This review covers only the registration part: the diff on top of #34, which is the new module plus the We fetched ÚDZS bulletin 1/2026 at the URL you cite, and both the PDF and the derived XSD match your SHA-256 values. We then checked the codec against F-511 and F-512 field by field. Header, payer row and body widths, the mandatory and optional flags, the one-of-three payer identifier, the RČ/BIČ alternative and the RRRRMMDD change date all agree. You also have the 2S schema defect right: the published pattern is On 19.0 under sk_SK we ran the SK and CZ declaration suites on Community, and the SK suites on Enterprise. The declaration-base refactor changes nothing for the existing declarations: CZ pvpoj, eldp, health, jmhz, onz and annual settlement, and SK mvp, vpp, eldp and health all give the same results as on 19.0. The new module itself has the failures listed below.
|
|
Registration review 6769032498 is addressed in the ready dependent contribution votrelec#7 at e82da27, based on the reviewed calendar/core architecture (#43). This preserves the already prepared local fixes and avoids bringing the superseded #34 evidence implementation back into the branch. After the core/calendar source sync I will update this upstream PR with the dependency commits removed. The update includes the refusal and force_storage cases, explicit test language, committed-cursor cleanup, schema provenance/SCHEMA_VERSION, 2P/2S calendar endpoints, readable user strings, aligned guide versions/copyright and a developer note for the four common hooks. Topic placement is stated in the PR description for your generator source. Unrelated HR-base catalogue export differences were removed after a separate review. The three-module Community regression passes 100 tests; actual default-Slovak registration passes 36, with loaded field/error probes. Two real HR-manager HTTP workflows pass, preserving retained XML/text and correction history with no retry duplicates. RST, native POT/SK, exact schema pins and full patch restoration pass. The Enterprise cleanup is included, but I do not claim an Enterprise runtime test. |
|
Closing this one as superseded, as you noted: the 601 registration notices continue in your votrelec#7, built on the recorded fund core (#43, now merged). We will review it there once it comes upstream. Thank you. |
Employer registration changes need their own HR-event source, independently of monthly payslips. This adds
l10n_sk_hr_payroll_health_registrationfor reviewed601 notices, using the common declaration, filing and submission-evidence workflow.Dependency: #34. This branch is based on its current head
2a6ad9d645108952ffa14530c56e10799c956c4b. Once that contribution lands, I will rebase onto the source sync so the review diff contains only this addition. The registration-specific diff isgit diff 2a6ad9d645108952ffa14530c56e10799c956c4b HEAD(30 files).The new module installs without a payroll engine. It provides reviewed employee events with Z/K/X, source references, company/HR access, optional reviewed coverage-calendar links, original N and explicit full O batches, XML and ISO8859-2 text output, and durable original attachments/source history. Calendar checks use unioned intervals; same-employer employment suppresses2D. If country payroll is installed, the version effective on the event date supplies the known health exemption. Only a2D start is refused: termination on the date exemption begins and cancellation remain available.
The common declaration module gains two small hooks:
_declaration_source_dataretains the existing payslip default and allows an HR-event provider; private_declaration_writepreserves the default ORM/access chain and lets a protected report retain workflow evidence without exposing a context bypass. The generate/reset/submit/archive orchestration remains shared. No second payroll ledger is introduced.Generated facts cannot be supplied via public create/write/default values. Parent locks serialize edits; the state and access are re-read after acquiring the lock. New filing evidence requires unchanged generated source. A filed original cannot silently become a different new filing. Protected attachment content allows identical-content storage migration and leaves unrelated chatter attachments alone.
The interface follows MU12/14/2014, updated10December2025, in the ÚDZS Bulletin1/2026. The schema is explicitly derived from the published PDF, with the source hash, extraction corrections and resulting hash documented beside it. It is not claimed to be an independently downloaded authority XSD. A valid-baseline negative control identifies the published2S XML pattern issue; text601 is the supported alternative when its charset represents the names. No lossy transliteration is performed.
Validation on Odoo19 in Docker:
Follow-up concurrency audit reproduced a stale generator snapshot after a committed HR-event edit. The parent now advances a non-key version so the stale transaction retries. The shared calendar fix from#34 is included as well. The final clean public payroll/health assembly passes269 tests, including both real two-transaction cases. The earlier955 result precedes these guards.
HR-only installation:24 tests,0 failures/errors; the optional payroll eligibility case is skipped when that module is absent.
Clean public payroll/calendar/monthly-health/registration assembly:263 tests,0 failures/errors.
Final registration cases after source/retry and filed-identity checks:28 tests,0 failures/errors, including dated optional payroll facts.
Full assembly with accounting, monthly/annual tax and existing payroll correction adapters:955 tests,0 failures/errors. The later registration guard changes are covered by the focused28-test run; they do not alter salary calculations.
Actual HTTP HR-manager workflow repeated twice: employee onchange, original XML, full corrective text, retained/downloaded bytes, Slovak
fields_getand a loaded PythonUserError. No system-administrator account or authority transport was used.Native Odoo POT export and Slovak merge: no untranslated active entries in the three affected module catalogs. Ruff0.13.0 format/check passes for the new module. The private documentation generator is unavailable in this public checkout, so no strict/generated-page build is claimed.
EN/SK documentation describes manual legal-event review, ePN notice responsibilities, source-calendar boundaries, assigned BIČ, explicit cancellations, corporate payers with IČO, the2S/charset limitation and separate authority acceptance. Actual irregular-income allocation and financial payroll corrections remain their own sources; this module does not infer or rewrite them merely because a notice was generated.
Follow-up review reproduced and fixed a filed-archive ownership gap after reset plus removal of working rows. Company, insurer, period, serial and correction identity now remain fixed. A native28-case run and two additional HR-manager HTTP/SK passes verify this boundary, including an unchanged date write. The failing reproduction is distinguished from the passing results; the earlier955 run is not claimed to cover this later guard.