Repository navigation
Conversation
Share the cooperative annual reader between pension defaults and annual calculation, preserving the default employment selection and existing checks. Exercise real annual results for separately reviewed facts after employment ends. Assisted-by: OpenAI Codex
The cross-company reader test already owns an employee/year reconciliation. Reuse it so the test reaches the actual company check instead of the valid unique-year constraint. Financial runtime is byte-identical. Assisted-by: OpenAI Codex
|
Thank you, this is a tidy and well-scoped extension point. The two call sites read the January tax fact through one reader, the default delegates to the existing employee reader, and the annual company and pension-consistency checks stay in What we checked Default behaviour is unchanged for stored records: The hook is a private method and adds no field, so nothing in it is settable or callable over RPC. The series applies cleanly with Requests
What we will do on our side Regenerate the rendered pages and The Enterprise engine's annual reconciliation does not need a mirror for this PR. Our parity gate checks module pairing and engine exclusivity, not method shapes, and passes unchanged, and your note correctly scopes the hook to the OCA annual model. If an Enterprise extension ever needs the same entry point, note that the Enterprise Verdict: approve once items 1 to 3 are addressed. We are also happy to make them on our side when we port, if that suits you better. |
Assert exact annual guards and reader calls; keep extension guidance in developer documentation and carry-over work in the active list. Assisted-by: OpenAI Codex
|
Addressed review items1-3 in cb7deab:
Normal startup and the six targeted reader tests pass with sk_SK loaded (0 failures,0 errors,exit0). The existing full343 result is retained; no production model changed in this followup. Rendered-page regeneration remains on your side as offered. Thank you for the precise review. |
|
Thank you, all three items verified. Merged into our 19.0 as d6b6d576. The three commits are squashed into one under your name (60169417), because the manifest line and changelog tail overlapped #49: the model, tests and DEVELOPER.md are byte-identical to your head, and the 19.0.1.26.2 entry and carry-over line were written onto the current changelog. On top of it (f04f0282): pages regenerated. 290/290 with sk_SK loaded (OCA, surcharges, MVP, VPP, parity). The change reaches this repository with the next sync. Closing here. |
3 source commit(s) since b12cbba7, 2 of which changed a module here. * [IMP] l10n_sk_hr_payroll_oca: expose annual January tax fact reader 60169417 — l10n_sk_hr_payroll_oca One cooperative singleton reader on the annual reconciliation for the January tax fact, used by the annual pension default and action_compute. The default delegates to the dated employee reader and keeps the draft fallback; an extension can supply a reviewed version for annual income after an employment ended. The company and pension-consistency checks still run after it. * [IMP] l10n_sk_hr_payroll_oca: pages as in cssk-public #51 f04f0282 — l10n_sk_hr_payroll_oca 207 modules in this repository. Co-authored-by: votrelec <votrelec@users.noreply.github.com>
Expose one cooperative singleton reader on the OCA annual reconciliation for the January tax fact. The annual pension default and action_compute both use it; the default delegates to the existing dated employee reader and retains the draft fallback and annual company/pension-consistency checks. Monthly payroll and employment dates stay unchanged.
Extensions can supply a separately reviewed native January version for annual income after employment ended. Evidence responsibilities, read-only repeated calls and OCA engine scope are documented in doc/DEVELOPER.md. User-facing EN/SK pages contain no developer extension section. The 18.0 carry-over task is in the active Unreleased list.
Validation: the prior complete343-test run passed with sk_SK loaded and stock OCA payroll. This QA/documentation-only review followup passed normal startup and all six targeted reader tests, exit0 without logger errors. The company and pension tests now require the specific English-context guard and an actual reader invocation. In a separate controlled source copy, reverting both call sites to the employee reader makes the pension test fail (1 failure,0 errors), proving it no longer passes on an unrelated ended-employment error. Production model files are unchanged by this followup.
Version19.0.1.26.2 follows the accepted monthly-wage hook release. Please regenerate the rendered pages with your generator at port.