Repository navigation
Conversation
Keep monthly allowance scope, lazy unsigned exit and January consistency policy while allowing cooperative owned evidence readers to use the same detached facts. No new fields, registers or tax parameters. Cover the existing default policy and the extension boundary. Assisted-by: OpenAI Codex
|
Thank you, this is a useful seam and the behaviour claim holds up. Monthly NČZD keeps its own employee/company check before the hook is reached, the unsigned declaration still returns before any January lookup, and the January company and pension-consistency checks now run on the hook's output, so an override cannot slip past them. What we checked on our side:
Changes we would like before merging:
Smaller points, take them or leave them:
Version: your entry jumps to 19.0.1.26.5, presumably leaving room for #54 and #55. That is fine as a placeholder; we assign the final numbers in the order the three are ported, so the number here will change. Verdict: changes requested, all of them small: docs to DEVELOPER.md with the call contract, no rewrap of untouched lines, the typo. The code itself we are happy with. |
Keep the allowance errors in their original layout and retain the user documentation for payroll operations. Co-authored-by: Codex <codex@openai.com>
Monthly allowance calculation currently reads declaration and January pension fields directly. Evidence adapters need the same dated facts; supplying a checked alternative source otherwise requires duplicating the allowance policy.
Add
_l10n_sk_monthly_tax_facts(version, *, include_january=False)as a cooperative scalar reader. Its default returns detached company/employee/version IDs, year and ISO cutoff, the signed flag and, when requested, facts from the existing native January-version lookup. No field or register is added, and caller dictionaries/context are not authority.Monthly NČZD keeps its own company/employee check before delegation, the unsigned early exit without January lookup, and the existing January company/pension-consistency checks and dated parameter. Evidence integrations can call the same reader with January explicitly requested; providers remain responsible for checking their owned source, relevant year and provenance.
Validation:32 targeted native Odoo19 cases passed:6 new reader/extension-boundary regressions plus existing monthly/annual tax, wage-hook and2027 parameter cases. A separate fresh normal registry verified actual payroll-Officer access without System/payrollManager/sudo in READ ONLY, unchanged version metadata and detached output. An actual-method comparison covers144 default combinations; the other20 existing model methods remain AST-identical. New tests are in the existing class, avoiding another inherited full-suite repetition. Ruff and
git diff --checkpass. No new translatable messages were introduced. EN/SK source docs and18.0 carry-over are recorded; the generated-repository docs tool is absent, so generated output is not claimed. OCA only; Enterprise/18.0 are untested.This changes the fact-reading seam, not statutory amounts, stored declarations, payroll posting or live tax submissions.