Repository navigation
Conversation
Keep matching legacy definitions and earlier/later dates usable. Validate native copy conflicts without changing stored definitions or payroll values. Assisted-by: OpenAI Codex
Add the ordinary payroll reader regression and preserve existing catalogs while adding the native exported error. Document the effective-date correction workflow. Assisted-by: OpenAI Codex
|
Thank you, this is a real gap and the fix is well scoped. The reader picked What we checked on our side:
Tests: our baseline on 19.0 is 290 green; with this PR 299 green (your nine new tests included). With only the model change reverted, four of the nine fail (native copy, older conflict, nested type conflict, payroll user), so the tests do guard the fix. A few suggestions, none of them blocking:
Version: 19.0.1.26.3 is fine as a placeholder. #54, #55 and #56 each claim a number after 19.0.1.26.2 and we assign the final ones in the order they are ported, so please do not worry about collisions. Verdict: approve. Happy to merge as is; the int/float point and the |
Assisted-by: OpenAI Codex
The OCA parameter reader currently accepts conflicting definitions at the same effective date. A native copy of a value
1to value2with the same date leaves calculation dependent on SQL tie order.Select the latest effective date deterministically and check its evaluated definitions. Matching legacy rows remain readable; conflicting values raise a translated error. Earlier conflicts do not block a later unambiguous definition. The reader does not rewrite parameters or retained payroll. No uniqueness constraint or historical-data migration is added.
Validation: 18 targeted native Odoo 19 tests passed, including native copy, nested values, date boundaries, ordinary payroll read-only permissions and existing parameter regressions. A separate fresh normal registry verified the actual Slovak UserError and field translation under a non-System payroll user in a READ ONLY transaction, with stored definitions unchanged. Native POT export and SK/CS merge preserve all existing 303 catalog entries. Ruff and
git diff --checkpass. The documentation generator is absent from this generated repository, so only EN/SK source docs were edited; generated README output was not claimed. OCA only; Enterprise and the 18.0 carry-over are not tested.The change is generic parameter integrity functionality. No statutory amounts or salary formulas are changed.