feat: dialect aware sketch decomposition - #2581
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
52437d2 to
33dffa9
Compare
shangyian
left a comment
There was a problem hiding this comment.
It looks like the new family-decomposition lookup doesn't check which aggregate call it's being asked about?
get_decomposition()applies a metric's sketch family to every aggregate in the formula- then
_attach_reaggregate_paramsbroadcasts sketch tuning params onto every component
I think that means it adds reaggregate.params onto every component with aggregation and merge set... so AVG which decomposes into SUM + COUNT will both get the sketch's params attached.
Separately should we add merge_args/serialize etc to MetricComponent so that GraphQL is equivalent with REST?
|
74acedf to
568e91a
Compare
Pass the output dialect and source aggregation call through metric decomposition so dialect-specific combiners can be rendered correctly. Add family-based registration so sketch decompositions can be selected explicitly through a metric's reaggregation spec.
Allow components to serialize accumulated values for specific materialization targets and declare the resulting type. Add multi-argument type inference and fixed merge arguments so t-digest measures retain the correct representation and compression when written to Druid.
4e64fd8 to
8731269
Compare
Summary
Rebase of #2559, since I feel bad that GitHub messed up @robinld's PRs. 😆
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan