Repository navigation
Keep DataLab 1.4 open in the live tests - #8
Merged
Merged
Conversation
The live tests start DataLab with DATALAB_DO_NOT_QUIT=1 so that it stays open in unattended mode. DataLab 1.4 reads its execution environment from SigimaX, whose variable is SIGIMAX_DO_NOT_QUIT: DataLab quit right after starting and every live test errored. Both variables are now set, so that the live tests run with DataLab 1.3 and 1.4. Closes #7 Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
_start_datalab()\ now sets \SIGIMAX_DO_NOT_QUIT=1\ (read by DataLab 1.4 through SigimaX) in addition to \DATALAB_DO_NOT_QUIT=1\ (DataLab 1.3). Release note added.
*Verification against DataLab \develop* (without setting the variable by hand): the live tests now run — 47 passed, versus 6 errors at startup without the fix. The remaining failure, \ est_rename, is a DataLab 1.4 regression, not a harness issue: re-uploading a downloaded object (which carries its UUID) under another name hangs the Web API (DataLab-Platform/DataLab#434, fixed separately). The CI of \main\ installs DataLab 1.3 from PyPI and is not affected.