Repository navigation
fix: make computing feature lookup deterministic - #372
Merged
Merged
Conversation
History replay ran the built-in feature when a plugin feature shared its name. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the merge of
developinto the plugin SDK branch by making feature identity explicit and lookups deterministic.get_feature(name)no longer depends on registration order: built-in features are preferred, or features from the recorded plugin module whenplugin_originis given (History replay and re-processing pass it). Previously, replaying a plugin feature that shares its name with a built-in feature ran the built-in one.compute_1_to_1calls now honour the registeredpreview_enabledflag (the lookup used the function name on a registry keyed by function, so it always missed).ComputingFeature.feature_id/BaseProcessor.get_feature_id(). Values are unchanged (function names).transpose"Swap X/Y axes" registration, which no menu reached (the Geometry menu resolvestransposeto "Flip diagonally"). No visible change.Full suite: 631 passed, 3 skipped (develop baseline: 628 passed, 3 skipped).
Assisted-by: Claude Opus 5.5