Repository navigation
test: fix live preview test closing its dialog on Qt 6 - #373
Merged
Merged
Conversation
QApplication.quit() closes top-level windows with Qt 6; exit() only leaves the loop. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_live_image_to_signal_previewfails on the PyQt6 workflow ondevelop(e.g. run 36858370695) and on PR #372.The test stopped the application event loop with
QApplication.quit(). With Qt 6,quit()also closes every top-level window, so the preview dialog was hidden beforeplotwidget.isVisible()was checked.QApplication.exit()leaves the loop without closing windows. A localQEventLoopis not an option: with Qt 5, an earlierquit()makes it return immediately.Verified locally: the original test fails under PyQt6 6.11 exactly as in CI; with the fix,
processing_preview_unit_test.pypasses under both PyQt5 and PyQt6 (25/25).Assisted-by: Claude Opus 5.5